Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully deprecate controller resolver auto mapping #1804

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

bobvandevijver
Copy link
Contributor

Symfony 7.1 has deprecated the use of the controller resolver auto mapper functionality in favour of the new mapped route parameters, which have the benefit of being explicit and concise (see symfony/symfony#54455, symfony/symfony#54720 and https://symfony.com/blog/new-in-symfony-7-1-mapped-route-parameters for the discussion and more details).

Note that we already deprecated not setting a value with #1762 to be able to change its default to false with 3.0, but now I propose to fully remove this configuration option with 3.0 instead, with both not setting and true being deprecated. Depending on when 3.0 would be available, removed the option could be postponed to 4.0 if desired.

/cc @nicolas-grekas - symfony/recipes#1316

@bobvandevijver bobvandevijver changed the base branch from 2.12.x to 2.13.x May 30, 2024 11:02
UPGRADE-2.13.md Outdated Show resolved Hide resolved
Copy link
Member

@ostrolucky ostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry it took a while to review, but tests need to be adjusted

Remaining self deprecation notices (100)

  100x: Since doctrine/doctrine-bundle 2.13: Enabling the controller resolver automapping feature has been deprecated. Symfony Mapped Route Parameters should be used as replacement.
    6x in DoctrineExtensionTest::testCacheConfiguration from Doctrine\Bundle\DoctrineBundle\Tests\DependencyInjection
    3x in DoctrineExtensionTest::testAutomapping from Doctrine\Bundle\DoctrineBundle\Tests\DependencyInjection
    2x in DoctrineExtensionTest::testDependencyInjectionConfigurationDefaults from Doctrine\Bundle\DoctrineBundle\Tests\DependencyInjection
    2x in DoctrineExtensionTest::testSingleEntityManagerWithEmptyConfiguration from Doctrine\Bundle\DoctrineBundle\Tests\DependencyInjection
    2x in DoctrineExtensionTest::testControllerResolver from Doctrine\Bundle\DoctrineBundle\Tests\DependencyInjection
    ...

@ostrolucky ostrolucky merged commit 568affa into doctrine:2.13.x Jun 24, 2024
15 checks passed
@bobvandevijver
Copy link
Contributor Author

bobvandevijver commented Jun 24, 2024

@ostrolucky No worries. I added the message to the baseline-ignore only, as I believe that the tests shouldn't be changed at this moment. The warning comes from the current configuration default, so it should be automatically solved when changing that in the future.

edit: ah, you're quick, great 👍

@bobvandevijver bobvandevijver deleted the mapped-route-parameters branch June 24, 2024 08:59
@ostrolucky ostrolucky added this to the 2.13.0 milestone Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants