Switch to a modern directory structure #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are the steps I followed: - `mkdir src` - `git mv *.php src` - `git mv Command/ DependencyInjection Loader Purger src` - adjust autoloading path - overrode `Bunde::getPath()` - `git mv Resources/doc/ docs` - `git mv Resources/config/ config` - `git mv Tests/ tests`
greg0ire
commented
Mar 29, 2024
| "psr-4": { "Doctrine\\Bundle\\FixturesBundle\\": "src" } | ||
| }, | ||
| "autoload-dev": { | ||
| "psr-4": { "Doctrine\\Bundle\\FixturesBundle\\Tests\\": "tests" } |
There was a problem hiding this comment.
This is technically a breaking change, because Tests is no longer autoloadable by users of this bundle. Looking at the files in there though, there does not seem to be any code that should be.
There was a problem hiding this comment.
The tests-directory shouldn't even be considered as usable outside of the bundle itself.
SenseException
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the steps I followed:
mkdir srcgit mv *.php srcgit mv Command/ DependencyInjection Loader Purger srcBunde::getPath()git mv Resources/doc/ docsgit mv Resources/config/ configgit mv Tests/ tests