MemArena: Add Darwin implementation #13269
Open
+241
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OatmealDome
force-pushed
the
memarena-darwin
branch
from
2b1d2c7 to
41c74b8
Compare
BhaaLseN
approved these changes
Jan 8, 2025
OatmealDome
force-pushed
the
memarena-darwin
branch
from
41c74b8 to
9b3b6be
Compare
|
OK, I resolved your comments (made everything constexpr). I also had this PR tested on an Intel Mac and an M1 Mac, and no problems were found.
I answered this on Discord, but reposting it here for completeness: while this code will be used on macOS going forward, there should be no user-visible changes from this PR. Theoretically, there might be an extremely minor performance benefit due to the kernel APIs being called directly instead of going through POSIX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements all the
MemArenaandLazyMemoryRegionfunctions using Mach APIs. We can't use the generic Unix implementation on some Apple platforms as they don't support shared memory. However, we can easily re-create the existing functionality withmach_make_memory_entry_64.Also, I use the normal
vmAPIs instead as the newermach_vmAPIs aren't available on those same platforms. As far as I can tell, themach_vmAPIs were introduced to properly handle a scenario where virtual memory is manipulated cross-process and the architectures differ (for example, one is 32-bit and the other is 64-bit). We don't need to worry about that.First part in a (probably very long) PR series, as previously discussed.