bypass unused param #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/Incidents/HTMLClip.js
Outdated
| @@ -13,7 +14,7 @@ import { HTMLClip } from "@donkeyclip/motorcortex"; | |||
| */ | |||
| export default class MyHTMLClip extends HTMLClip { | |||
| get html() { | |||
| return "<div></div>"; | |||
| return <div></div>; | |||
There was a problem hiding this comment.
🚫 [eslint] reported by reviewdog 🐶
Parsing error: This experimental syntax requires enabling one of the following parser plugin(s): "jsx", "flow", "typescript". (17:11)
There was a problem hiding this comment.
@andreas-trad you also got to fix this, before merging
📊 Package size report 3%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
alexdor
requested changes
Nov 23, 2023
src/Incidents/HTMLClip.js
Outdated
| @@ -13,7 +14,7 @@ import { HTMLClip } from "@donkeyclip/motorcortex"; | |||
| */ | |||
| export default class MyHTMLClip extends HTMLClip { | |||
| get html() { | |||
| return "<div></div>"; | |||
| return <div></div>; | |||
There was a problem hiding this comment.
@andreas-trad you also got to fix this, before merging
| @@ -2,7 +2,7 @@ import babel from "@rollup/plugin-babel"; | |||
| import commonjs from "@rollup/plugin-commonjs"; | |||
| import json from "@rollup/plugin-json"; | |||
| import resolve from "@rollup/plugin-node-resolve"; | |||
| import { terser } from "rollup-plugin-terser"; | |||
| import terser from '@rollup/plugin-terser'; | |||
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace '@rollup/plugin-terser' with "@rollup/plugin-terser"
Suggested change
| import terser from '@rollup/plugin-terser'; | |
| import terser from "@rollup/plugin-terser"; |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr enables jsx for plugin development