forked from anchore/syft
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for new Copyrights and schema updates #2
Open
dor-hayun
wants to merge
12
commits into
main
Choose a base branch
from
support-copyrights
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dor-hayun
force-pushed
the
support-copyrights
branch
2 times, most recently
from
August 27, 2024 10:33
18aea9c
to
1a60f72
Compare
dor-hayun
force-pushed
the
support-copyrights
branch
3 times, most recently
from
August 27, 2024 11:38
c0d17ac
to
b003b36
Compare
The official CPE for curl is `cpe:2.3:a:haxx:curl:*:*:*:*:*:*:*:*` Signed-off-by: Weston Steimel <commits@weston.slmail.me>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
dor-hayun
force-pushed
the
support-copyrights
branch
2 times, most recently
from
August 27, 2024 14:07
80c2386
to
9043e0c
Compare
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
dor-hayun
force-pushed
the
support-copyrights
branch
from
August 27, 2024 14:38
9043e0c
to
c8bba15
Compare
…classifiers (anchore#3167) Signed-off-by: Weston Steimel <commits@weston.slmail.me>
dor-hayun
force-pushed
the
support-copyrights
branch
5 times, most recently
from
August 28, 2024 12:20
43aeb7a
to
1e121e8
Compare
dor-hayun
force-pushed
the
support-copyrights
branch
2 times, most recently
from
August 28, 2024 12:57
b113b35
to
052f526
Compare
dor-hayun
force-pushed
the
support-copyrights
branch
2 times, most recently
from
August 28, 2024 13:41
d27e313
to
abf35cc
Compare
Signed-off-by: tomersein <tomersein@gmail.com>
…nchore#3169) The existing syft binary classifiers already specify any known CPEs for the defined binary; however, sometimes these end up getting suppressed (such as when there are ELF notes extracted) and the CPE generator ends up being used instead. This adds enough detail to at least ensure the correct ones get appended to the generation list for the currently covered classifiers. Signed-off-by: Weston Steimel <commits@weston.slmail.me>
…ariables (anchore#3170) Signed-off-by: Keith Zantow <kzantow@gmail.com>
…chore#3175) Signed-off-by: Mikail Kocak <mikail-gh@pm.me>
dor-hayun
force-pushed
the
support-copyrights
branch
from
September 1, 2024 06:52
abf35cc
to
4bf0b03
Compare
- **Added**: New JSON schema version `16.0.16` with support for the new `Copyrights`. - **Modified**: Updated the `JSONSchemaVersion` parameter to use the new schema. - **Added**: New `Copyrights` field to the `Package` and `PackageBasicData` structs, similar to the existing `Licenses` field. - **Added**: New `Copyright` struct. - **Implemented**: Sorting methods for the `Copyright` struct. - **Changed**: Updated the `PackageCopyrightText` to use `helpers.GetCopyrights(p.Copyrights)`, which formats the copyright text and returns a string. Example output: "Copyright 2014-2014 Matt Zabriskie & Collaborators". - **Added**: `Copyrights` assignment to the `toSyftPackage` function. Signed-off-by: dor-hayun <dor.hayun@mend.io>
dor-hayun
force-pushed
the
support-copyrights
branch
from
September 1, 2024 07:34
4bf0b03
to
b75dd28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON Schema
16.0.16
with support for the newCopyrights
.JSONSchemaVersion
parameter to use the new schema.Package Structs
Copyrights
field to thePackage
andPackageBasicData
structs, similar to the existingLicenses
field.Copyright
struct.Copyright
struct.toPackages Function
PackageCopyrightText
to usehelpers.GetCopyrights(p.Copyrights)
, which formats the copyright text and returns a string. Example output: "Copyright 2014-2014 Matt Zabriskie & Collaborators".toSyftPackage Function
Copyrights
assignment to thetoSyftPackage
function.Signed-off-by: dor-hayun dor.hayun@mend.io