Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math - remap function #220

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

math - remap function #220

wants to merge 3 commits into from
+53 −0

Conversation

JasimAlrawie
Copy link

@JasimAlrawie JasimAlrawie commented Jan 9, 2025 •
edited
Loading

Description

remap function

a function that remaps values from range to another range

Type of Change

  • ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

Screenshots (Optional)

Click to view screenshots

Mathys-Gasnier
Mathys-Gasnier requested changes Jan 9, 2025
View reviewed changes
snippets/cpp/math-and-numbers/remap.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this doesnt use any cpp feature over the c version, please remove it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

majvax
majvax requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@majvax majvax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the function (and file) from remap to linear mapping or linear map as it don't make much sense to call it remap. I also don't like start1 start2.
It should be more explicit like min_in and min_out

@majvax majvax added the Snippets label Jan 9, 2025
majvax
majvax requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@majvax majvax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things to address + the title of each snippets should be Linear Mapping so it matches the file name.

Please carefully check for typo before requesting another review.

snippets/c/mathematical-functions/linear-mapping.md
@@ -0,0 +1,19 @@
---
title: Linear Remappibg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

snippets/python/math-and-numbers/linear-mapping.md
@@ -0,0 +1,17 @@
---
title: Linear Renapping
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

snippets/python/math-and-numbers/linear-mapping.md

```py

def linearMapping(value, minIn, maxIn, minOut, maxOut):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be lower_cased to follow pep8 standard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathys-Gasnier Mathys-Gasnier Mathys-Gasnier requested changes

@majvax majvax majvax requested changes

@psychlone77 psychlone77 Awaiting requested review from psychlone77 psychlone77 is a code owner

@saminjay saminjay Awaiting requested review from saminjay saminjay is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Snippets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasimAlrawie @majvax @Mathys-Gasnier