Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance Rust snippets #75

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pyyupsk
Copy link

@pyyupsk pyyupsk commented Jan 1, 2025

Description

Type of Change

  • ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

The changes introduce a variety of new Rust snippets.

Screenshots (Optional)

Click to view screenshots

Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for quicksnip ready!

Name Link
🔨 Latest commit 97c58d2
🔍 Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/677763650d5b8a0008023df6
😎 Deploy Preview https://deploy-preview-75--quicksnip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mathys-Gasnier
Copy link
Collaborator

Hey, we recently updated how snippets are stored, please update your PR to match the changes, you will be able to see how to add snippets in CONTRIBUTING.md.
For ref: #87

@pyyupsk pyyupsk closed this Jan 2, 2025
@pyyupsk pyyupsk deleted the feat/rust-snippets-enhancements branch January 2, 2025 04:01
@pyyupsk pyyupsk restored the feat/rust-snippets-enhancements branch January 2, 2025 04:01
@pyyupsk pyyupsk reopened this Jan 2, 2025
@pyyupsk pyyupsk requested a review from Mathys-Gasnier January 2, 2025 04:31
@pyyupsk
Copy link
Author

pyyupsk commented Jan 2, 2025

Hi @Mathys-Gasnier,

I’ve updated the snippets to match the new format and resolved the merge conflicts. Can you take a look and let me know if everything’s good or if there’s anything else I should fix? Thanks!

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for updating your snippets, but looking at your PR, it still seems to modify /public/consolidated/all_snippets.json which is a file that doesn't exists, the same goes for /public/data/rust.json

@dostonnabotov dostonnabotov added the update needed Code needs to be updated. label Jan 2, 2025
@pyyupsk pyyupsk requested a review from Mathys-Gasnier January 5, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Snippets update needed Code needs to be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants