Clarify meaning of the group name specified in WithGroupName

[mikekistler]

This PR makes a small change to the description of the value passed to WithGroupName to explain how it is used in OpenAPI document generation. The prior text was inaccurate because there is no "GroupName" in the OpenAPI specification.

[mikekistler]

This also seems confusing -- what does it mean to "set an attribute"?

Maybe this should say "Sets the IEndpointGroupNameMetadata" ? or ???

[captainsafia]

Yeah, I think this doc comment is attempting to apply a literal description of what this method is doing. It instantiates the EndpointGroupNameAttribute class and adds it to the metadata collection.

However, that's a means to an end for the real valuable thing which is the fact that EndpointGroupNameAttribute implements the IEndpointGroupNameMetadata interface. That's what's actually relevant here so I think your recommendation of referencing the interface instead of the class is a good one.

[captainsafia]

LGTM!

Maybe we can put the detail about group name mapping to the OpenAPI document in the docs for IEndpointGroupNameMetadata itself?

[dotnet-policy-service]

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.