Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor private PushAuthorizationRequest #59990

Open
wants to merge 1 commit into
base: release/9.0
Choose a base branch
from

Conversation

marcusber
Copy link

Refactor private PushAuthorizationRequest

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

An exception was created but not thrown. Make relevant changes to remove that.

Description

An exception was created but not thrown. When backtracking the usage of the private method, the PAR-endpoint was already guarded for empty PAR-enpoints.
Pass in the PAR-endpoint as non-null reference to the private method. Remove the exception that was created and not thrown.

Existing unit tests never reaches the private method due to guards in the calling method.

I'm not sure which branch this PR should target. It should be compatible with main when cherry-picked.

An exception was created but not thrown. When backtracking the usage of the private method, the PAR-endpoint was already guarded for empty PAR-enpoints.
The initial guard for empty is there for future usages, the call is redundant now.
@marcusber
Copy link
Author

@dotnet-policy-service agree

Copy link
Contributor

Thanks for your PR, @marcusber. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 22, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.x milestone Jan 22, 2025
Copy link
Contributor

Hi @marcusber. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-security community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant