This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Do not trim spaces at the beginning in copyright header comment #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The copyright header rule trims spaces at the begginings of code comment lines. However, it does not perform the same operation for raw texts. That difference makes the rule think a code comment line and a raw text line different even if they are same. Such a raw text including a line beginning with spaces include Apache-2.0's copyright notice. This change fixes the problem by removing the code trimming spaces. Additionally, this change takes spaces added when introducing new copyright headers into account.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copyright header rule trims spaces at the begginings of code comment lines. However, it does not perform the same operation for raw texts. That difference makes the rule think a code comment line and a raw text line different even if they are same. Such a raw text including a line beginning with spaces include Apache-2.0's copyright notice.
This change fixes the problem by removing the code trimming spaces. Additionally, this change takes spaces added when introducing new copyright headers into account.