[Testing] Enabling WebView UITests from Issues folder in Appium #27284
Conversation
NafeelaNazhir
added
the
partner/syncfusion
|
Hey there @NafeelaNazhir! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
NafeelaNazhir
added
area-testing
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
NafeelaNazhir
changed the title
There was a problem hiding this comment.
Copilot reviewed 8 out of 23 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- src/Controls/tests/TestCases.HostApp/Issues/Issue21846Modal.xaml: Language not supported
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21846.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21631.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/MemoryTests.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16032.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue4720.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18452.cs: Evaluated as low risk
- src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue6323.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla35733.cs: Evaluated as low risk
- src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue4720.cs: Evaluated as low risk
- src/Controls/tests/TestCases.HostApp/Issues/Bugzilla/Bugzilla35733.cs: Evaluated as low risk
- src/Controls/tests/TestCases.HostApp/Issues/MemoryTests.cs: Evaluated as low risk
- src/Controls/tests/TestCases.HostApp/Issues/Issue16032.cs: Evaluated as low risk
- src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue6286.cs: Evaluated as low risk
- src/Controls/tests/TestCases.HostApp/Issues/Issue21846.xaml.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue12134.cs:24
- The word 'Failied' is misspelled. It should be 'Failed'.
App.WaitForElement("Success", "Failied on: {i}");
| @@ -4,7 +4,7 @@ namespace Maui.Controls.Sample.Issues | |||
| { | |||
|
|
|||
| [Issue(IssueTracker.Github, 12134, "[iOS] WkWebView does not handle cookies consistently", | |||
| PlatformAffected.iOS)] | |||
| PlatformAffected.iOS, isInternetRequired: true)] | |||
There was a problem hiding this comment.
This is a public API change and could be a breaking change. Ensure that this change is documented and communicated properly.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| @@ -236,6 +236,21 @@ but both can happen. | |||
| } | |||
| } | |||
|
|
|||
| protected void VerifyInternetConnectivity() | |||
There was a problem hiding this comment.
Already have it here
Create it in
UITest.cs and use the same implementation where needed like we do with VerifyScreenshot. So, leave this implementation and update Issue 3262.
There was a problem hiding this comment.
I have updated Issue3262 in the latest changes.
| @@ -236,6 +236,21 @@ but both can happen. | |||
| } | |||
| } | |||
|
|
|||
| protected void VerifyInternetConnectivity() | |||
There was a problem hiding this comment.
Would be interesting to implement a parameter: TimeSpan? retryDelay = null
Allow to retry.
There was a problem hiding this comment.
@jsuarezruiz , The ValidateInternetConnection method does not necessarily require a retry mechanism, as the host app already verifies the internet connection when loading the sample page itself. This method's primary purpose is to confirm that the page is displayed during the initial test execution. We believe that implementing a retry would be unnecessary and redundant. However, if you have particular use cases where a retry mechanism could be beneficial, we are open to considering those scenarios.
Description of Change
This PR focuses on enabling and updating 11 testcases in Appium. The tests, previously ignored using Fails attribute, are reviewed, and modified to ensure they are functional with the Appium framework. We are going to enable tests in blocks in different PRs.
TestCases: