-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Layout): add media query for overflow style #5051
Conversation
Reviewer's Guide by SourceryThis PR adds a media query to apply overflow styling to the layout-right element only on smaller screens (max-width: 767.99px). State diagram for responsive layout behaviorstateDiagram-v2
[*] --> LayoutExpanded
LayoutExpanded --> LayoutCollapsed: User collapses sidebar
LayoutCollapsed --> LayoutExpanded: User expands sidebar
state LayoutCollapsed {
[*] --> Desktop: width >= 768px
[*] --> Mobile: width < 768px
Desktop --> Mobile: Resize window
Mobile --> Desktop: Resize window
state Mobile {
[*] --> HiddenOverflow
note right of HiddenOverflow
layout-right has:
overflow: hidden
height: var(--bb-layout-height)
end note
}
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5051 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27964 27964
Branches 4008 4008
=========================================
Hits 27964 27964 ☔ View full report in Codecov by Sentry. |
add media query for overflow style
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5050
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a media query to apply overflow style to the layout right section only on smaller screens (max-width 767.99px).
Bug Fixes:
Enhancements: