-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SmilesDrawer): add SmilesDrawer component #5073
Conversation
# Conflicts: # src/BootstrapBlazor.Server/Locales/zh-CN.json
Reviewer's Guide by SourceryThis pull request introduces a new SmilesDrawer component that visually renders molecules from SMILES strings. It includes a sample page with demonstrations of the component and its size customization options. Class diagram for SmilesDrawer component and optionsclassDiagram
class SmilesDrawer {
+string Smiles
+SmilesDrawerOptions Options
}
class SmilesDrawerOptions {
+string Theme
+int Width
+int Height
}
SmilesDrawer --> SmilesDrawerOptions : uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template sections, particularly the Risk assessment and Verification details. This helps reviewers better understand the impact of the changes.
- Consider adding documentation that explains what SmilesDrawer is and its intended use case for developers who may not be familiar with molecular visualization.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5073 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27969 27969
Branches 4010 4010
=========================================
Hits 27969 27969 ☔ View full report in Codecov by Sentry. |
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add documentation explaining what SMILES notation is, the supported format/syntax, and example use cases for the SmilesDrawer component. This will help users understand how to effectively use this specialized component.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
add SmilesDrawer component
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5068
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a SmilesDrawer component to display molecular structures using SMILES strings.
New Features:
Tests: