Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): avoid throwing #2427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gregoirevda
Copy link

getUri returns null when the key doesn't exist, but throws when it is empty string
https://github.com/doublesymmetry/react-native-track-player/blob/main/android/src/main/java/com/doublesymmetry/trackplayer/utils/BundleUtils.kt#L15

If the artwork is empty string instead of null, it will throw and prevent the whole audio to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant