Skip to content

Commit

Permalink
Splat exception_metadata into span.log_kv (#9)
Browse files Browse the repository at this point in the history
  • Loading branch information
Austio authored Sep 28, 2022
1 parent d252db6 commit 3c599af
Show file tree
Hide file tree
Showing 17 changed files with 16 additions and 14 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
Changelog
=========

## 0.6.1 09/07/2022
* Update for ruby 3.x compatibility
* Splat hash when passing method expecting keyword args

## 0.6.0 07/11/2022
* Improved pper address tag to reflect the current database when using the mysql adapter

Expand Down
22 changes: 10 additions & 12 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,31 +1,30 @@
PATH
remote: .
specs:
activerecord-instrumentation (0.6.0)
activerecord-instrumentation (0.6.1)
activerecord
opentracing (~> 0.5)

GEM
remote: https://rubygems.org/
specs:
activemodel (6.1.6.1)
activesupport (= 6.1.6.1)
activerecord (6.1.6.1)
activemodel (= 6.1.6.1)
activesupport (= 6.1.6.1)
activesupport (6.1.6.1)
activemodel (7.0.4)
activesupport (= 7.0.4)
activerecord (7.0.4)
activemodel (= 7.0.4)
activesupport (= 7.0.4)
activesupport (7.0.4)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 1.6, < 2)
minitest (>= 5.1)
tzinfo (~> 2.0)
zeitwerk (~> 2.3)
ast (2.4.0)
concurrent-ruby (1.1.10)
diff-lcs (1.3)
i18n (1.11.0)
i18n (1.12.0)
concurrent-ruby (~> 1.0)
jaro_winkler (1.5.4)
minitest (5.16.2)
minitest (5.16.3)
opentracing (0.5.0)
opentracing_test_tracer (0.1.1)
opentracing
Expand Down Expand Up @@ -63,10 +62,9 @@ GEM
sdoc (1.1.0)
rdoc (>= 5.0)
sqlite3 (1.4.2)
tzinfo (2.0.4)
tzinfo (2.0.5)
concurrent-ruby (~> 1.0)
unicode-display_width (1.6.1)
zeitwerk (2.6.0)

PLATFORMS
ruby
Expand Down
2 changes: 1 addition & 1 deletion lib/active_record/open_tracing/processor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def call(_event_name, start, finish, _id, payload)

if (exception = payload[:exception_object])
span.set_tag("error", true)
span.log_kv(exception_metadata(exception))
span.log_kv(**exception_metadata(exception))
end

span.finish(end_time: finish)
Expand Down
2 changes: 1 addition & 1 deletion lib/active_record/open_tracing/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module ActiveRecord
module OpenTracing
VERSION = "0.6.0"
VERSION = "0.6.1"
end
end
Binary file removed vendor/cache/activemodel-6.1.6.1.gem
Binary file not shown.
Binary file added vendor/cache/activemodel-7.0.4.gem
Binary file not shown.
Binary file removed vendor/cache/activerecord-6.1.6.1.gem
Binary file not shown.
Binary file added vendor/cache/activerecord-7.0.4.gem
Binary file not shown.
Binary file removed vendor/cache/activesupport-6.1.6.1.gem
Binary file not shown.
Binary file added vendor/cache/activesupport-7.0.4.gem
Binary file not shown.
Binary file removed vendor/cache/i18n-1.11.0.gem
Binary file not shown.
Binary file added vendor/cache/i18n-1.12.0.gem
Binary file not shown.
Binary file removed vendor/cache/minitest-5.16.2.gem
Binary file not shown.
Binary file added vendor/cache/minitest-5.16.3.gem
Binary file not shown.
Binary file removed vendor/cache/tzinfo-2.0.4.gem
Binary file not shown.
Binary file added vendor/cache/tzinfo-2.0.5.gem
Binary file not shown.
Binary file removed vendor/cache/zeitwerk-2.6.0.gem
Binary file not shown.

0 comments on commit 3c599af

Please sign in to comment.