fix: default value for the time format should be empty #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys.
I've been using your theme for a while already and I've noticed that all time based options are not getting applied.
I've checked source code for the
dracula.sh
and I've noticed that option@dracula-time-format
has a default value.If we check time plugin source code we'll notice that if
time_format
isn't empty then it'll be used instead of the theme provided formats:The problem is even if I specify an empty value for the
@dracula-time-format
option - script will use a default value. This means that this theme will always use a custom time format specified, ignoring all other options.Please see the following screenshots:
Thanks!