feat: implement connection timeout functionality #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
Pr2
branch
5 times, most recently
from
c09c45c to
cc30718
Compare
adiholden
reviewed
Jan 9, 2025
|
|
||
| ABSL_FLAG(uint32_t, interpreter_per_thread, 10, "Lua interpreters per thread"); | ||
| ABSL_FLAG(uint32_t, timeout, 0, |
There was a problem hiding this comment.
maybe rename to connection_timeout?
There was a problem hiding this comment.
do you intend to change the default in the future?
There was a problem hiding this comment.
the name and the default value are compatible with valkey. see https://github.com/valkey-io/valkey/blob/unstable/valkey.conf#L161
adiholden
reviewed
Jan 9, 2025
adiholden
reviewed
Jan 9, 2025
romange
force-pushed
the
Pr2
branch
3 times, most recently
from
3540dc3 to
eea9821
Compare
`timeout` argument shuts down idle connections after the specified time. Fixes #1677 Signed-off-by: Roman Gershman <roman@dragonflydb.io>
adiholden
reviewed
Jan 20, 2025
adiholden
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeoutargument shuts down idle connections after the specified time.Fixes #1677