Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#43] Fixed compatibility with Drivers other than Selenium. #144

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

AlexSkrypnyk
Copy link
Member

Closes #43

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.23%. Comparing base (52f2864) to head (e2abe03).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tScreenshotExtension/Context/ScreenshotContext.php 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   89.95%   89.23%   -0.72%     
==========================================
  Files           4        4              
  Lines         229      223       -6     
==========================================
- Hits          206      199       -7     
- Misses         23       24       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/43-compat-non-selenium branch from e20cc0f to 534987b Compare January 18, 2025 05:25
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/43-compat-non-selenium branch from 534987b to e2abe03 Compare January 18, 2025 05:28
@AlexSkrypnyk AlexSkrypnyk enabled auto-merge (rebase) January 18, 2025 05:28
@AlexSkrypnyk AlexSkrypnyk merged commit 957dd0a into main Jan 18, 2025
4 of 5 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/43-compat-non-selenium branch January 18, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make initialisation consistent for Selenium and non-Selenium drivers
1 participant