Fixed SQLite version in CI. #643
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ env: | |
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
|
|
@@ -35,11 +35,20 @@ jobs: | |
| - name: Checkout | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Upgrade sqlite3 | ||
| run: | | ||
| wget https://www.sqlite.org/2024/sqlite-autoconf-3450300.tar.gz -O /tmp/sqlite.tar.gz | ||
|
There was a problem hiding this comment. GHA images do not have the latest version of SQLite yet. We need to build it from source. This may need to be optimised later. Will be removed once SQLite is added to GHA images There was a problem hiding this comment. |
||
| tar -xzf /tmp/sqlite.tar.gz -C /tmp | ||
| cd /tmp/sqlite-autoconf-3450300 | ||
| ./configure CFLAGS="-DSQLITE_ENABLE_COLUMN_METADATA=1" --prefix=/usr/local | ||
| make && sudo make install | ||
| sudo ldconfig | ||
|
|
||
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: ${{ matrix.php-versions }} | ||
| extensions: gd, sqlite, pdo_sqlite | ||
|
There was a problem hiding this comment. explicitly call out |
||
|
|
||
| - name: Update composer | ||
| run: composer --verbose self-update --${{ matrix.composer-channel }} | ||
|
|
@@ -54,7 +63,7 @@ jobs: | |
| run: composer --verbose install | ||
|
|
||
| - if: matrix.drupal-release == 'dev' | ||
| run: composer --verbose require --no-update drupal/core-recommended:11.0.x-dev && composer --verbose require --no-update --dev drupal/core-dev:11.0.x-dev | ||
|
There was a problem hiding this comment. this is an oversight that should have been addressed in my previous PR. sorry |
||
|
|
||
| - if: matrix.drupal-release == 'dev' | ||
| run: composer --verbose update | ||
|
|
@@ -66,6 +75,6 @@ jobs: | |
| - run: until curl -s $SIMPLETEST_BASE_URL; do true; done > /dev/null | ||
|
|
||
| - name: Run a single unit test to verify the testing setup. | ||
| run: ./vendor/bin/phpunit -c ./web/core $(pwd)/web/core/modules/user/tests/src/Unit/UserAccessControlHandlerTest.php | ||
|
There was a problem hiding this comment. Latest D11-dev changed the way the relative path discovered. Using absolute for now. This change is not relevant to this project's functionality. https://www.drupal.org/project/drupal/issues/3417066 |
||
|
|
||
| - run: ./vendor/bin/drush | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should run on latest by default. if needed - we can introduce running on older versions in another PR