Unit tests for User #11
Conversation
Added getSessionKeys function to allow testing for setSessionKeysToNullify Added tests for UserAuthenticator functions
tests/src/Unit/SocialApiUserTest.php
Outdated
| */ | ||
| public function testSetPluginId() { | ||
| $this->assertEquals(NULL, $this->userManager->getPluginId()); | ||
| $this->userManager->setPluginId('social_auth_mixer'); |
There was a problem hiding this comment.
Let's change it to 'social_auth_test'
tests/src/Unit/SocialApiUserTest.php
Outdated
| $this->assertTrue( | ||
| method_exists($this->userManager, 'getPluginId'), | ||
| 'UserManager class does not implements getPluginId function/method' | ||
| ); | ||
| $this->assertTrue( | ||
| method_exists($this->userManager, 'setPluginId'), | ||
| 'UserManager class does not implements setPluginId function/method' | ||
| ); | ||
| $this->assertTrue( | ||
| method_exists($this->userManager, 'getDrupalUserId'), | ||
| 'UserManager class does not implements getDrupalUserId function/method' | ||
| ); | ||
| } |
There was a problem hiding this comment.
Unless the class is inheriting from an abstract class, we don't need to check this. I don't know if that's the case off the top of my head
tests/src/Unit/SocialApiUserTest.php
Outdated
| */ | ||
| public function testGetPluginId() { | ||
| $this->userManager->setPluginId('social_auth_mixer'); | ||
| $this->assertNotEquals('social_auth_reddit', $this->userManager->getPluginId()); |
There was a problem hiding this comment.
Just test that you're getting the correct value (again)
tests/src/Unit/SocialApiUserTest.php
Outdated
| * @covers Drupal\social_api\User\UserManager::getPluginId | ||
| */ | ||
| public function testGetPluginId() { | ||
| $this->userManager->setPluginId('social_auth_mixer'); |
tests/src/Unit/SocialApiUserTest.php
Outdated
| $this->assertTrue( | ||
| method_exists($this->userAuthenticator, 'getPluginId'), | ||
| 'UserAuthenticator class does not implements getPluginId function/method' | ||
| ); | ||
| $this->assertTrue( | ||
| method_exists($this->userAuthenticator, 'setPluginId'), | ||
| 'UserAuthenticator class does not implements setPluginId function/method' | ||
| ); | ||
| $this->assertTrue( | ||
| method_exists($this->userAuthenticator, 'getSessionKeys'), | ||
| 'UserAuthenticator class does not implements getSessionKeys function/method' | ||
| ); | ||
| $this->assertTrue( | ||
| method_exists($this->userAuthenticator, 'setSessionKeysToNullify'), | ||
| 'UserAuthenticator class does not implements setSessionKeysToNullify function/method' | ||
| ); | ||
| $this->assertTrue( | ||
| method_exists($this->userAuthenticator, 'nullifySessionKeys'), | ||
| 'UserAuthenticator class does not implements nullifySessionKeys function/method' | ||
| ); |
There was a problem hiding this comment.
Same as what I mentioned before
tests/src/Unit/SocialApiUserTest.php
Outdated
| $another_session = ['mpau82ass' => 'lplaw2b21', 'caholaaw' => '018y23czs']; | ||
|
|
||
| $this->userAuthenticator->setSessionKeysToNullify($sample_session); | ||
| $this->assertNotEquals($another_session, $this->userAuthenticator->getSessionKeys()); |
There was a problem hiding this comment.
You're better off checking that what you set is what you get in this cases. assertNotEquals is not convenient since the session keys might be NULL and that's still no equal.
| $this->assertEquals($sample_session, $this->userAuthenticator->getSessionKeys()); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
You might wanna add a test for nullifySessionKeys. That would probably require mocking the set and get methods of the data handler to use an arrray/map that you define in your test file.
|
While debugging I noticed that $session_key was a value not the key, after adding second argument in the callback, $session_key is a key, also I removed SessionPrefix because dataHandler->set adds it itself. |
src/User/UserAuthenticator.php
Outdated
| @@ -142,8 +152,8 @@ public function setSessionKeysToNullify(array $session_keys) { | |||
| */ | |||
| public function nullifySessionKeys() { | |||
| if (!empty($this->sessionKeys)) { | |||
| array_walk($this->sessionKeys, function ($session_key) { | |||
| $this->dataHandler->set($this->dataHandler->getSessionPrefix() . $session_key, NULL); | |||
| array_walk($this->sessionKeys, function ($value, $session_key) { | |||
There was a problem hiding this comment.
We don't pass a key => value pair to this function. $sessionKeys is supposed to be a simple array such as ['key1', 'key2']. Thus, this change has to be undone.
tests/src/Unit/SocialApiUserTest.php
Outdated
| $sample_session = ['h78323' => '78t2gq2g7q', 'pawdwadawd' => 'cbzhzxc']; | ||
|
|
||
| $this->assertNotEquals($sample_session, $this->userAuthenticator->getSessionKeys()); | ||
| $this->userAuthenticator->setSessionKeysToNullify($sample_session); |
There was a problem hiding this comment.
I believe that only the keys of $sample_session should be passed to setSessionKeysToNullify. See the first comment about reverting this function
|
I have merged this branch with #10 . Thank you! |
I've created unit tests for UserManager.php and UserAuthenticator.php