Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Update pipeline files #1989

Merged
merged 13 commits into from
Jan 13, 2024
Merged

SqlServerDsc: Update pipeline files #1989

merged 13 commits into from
Jan 13, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Dec 21, 2023

Pull Request (PR) description

  • SqlServer
    • Updated pipeline files to support pre-releases with ModuleFast (when
      resolving dependencies).

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Dec 21, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e67e58) 94% compared to head (f95f0fa) 94%.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1989   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files        93      93           
  Lines      7844    7844           
====================================
  Hits       7424    7424           
  Misses      420     420           
Flag Coverage Δ
unit 94% <ø> (ø)

@johlju johlju added on hold The issue or pull request has been put on hold by a maintainer. and removed needs review The pull request needs a code review. labels Dec 31, 2023
@johlju
Copy link
Member Author

johlju commented Dec 31, 2023

Waiting for ModuleFast to be released so that correct changes can be implemented in Sampler prior to adding them here.

@johlju johlju added needs review The pull request needs a code review. and removed on hold The issue or pull request has been put on hold by a maintainer. labels Jan 11, 2024
@johlju
Copy link
Member Author

johlju commented Jan 11, 2024

ModuleFast have been released and updated the files to the latest merged into Sampler.

@johlju johlju requested a review from a team as a code owner January 12, 2024 14:19
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 4 files at r1, 2 of 2 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 05da122 into main Jan 13, 2024
36 of 37 checks passed
@johlju johlju deleted the fix/update-pipeline-files branch January 13, 2024 17:11
@johlju johlju removed the needs review The pull request needs a code review. label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant