Poi Search via overpass API #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search for arbitrary POIs via overpass API, display them in an overlay, and update when the map is moved/zoomed.
Needs mhanne/dspace-api-core@956f93c and mhanne/dspace-ui-leaflet@4f8c25d to work.
Overpass also has an option to specify the search area as a polygon, so we could do incremental updates if we can calculate the subtraction and union of two polygons. Do we already have something that can do that as a dependency? I tried spatial_query and turf, but both don't seem to work with more complex polygons.
Also, add multiple basemaps to choose from; Sorry this got mixed in here, I can make a separate PR if you like.