Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update peer dependencies #186

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

marco10024
Copy link

In this PR:

  • Bug fix (non-breaking change which fixes an issue)

Issues reference:

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code with pnpm lint locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with pnpm test of your changes locally?

Copy link

socket-security bot commented Oct 7, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Environment variable access npm/consola@3.2.3 🚫
Environment variable access npm/consola@3.2.3 🚫
Environment variable access npm/consola@3.2.3 🚫
Environment variable access npm/consola@3.2.3 🚫
New author npm/@ducktors/tsconfig@1.0.0 🚫
Trivial Package npm/@ducktors/tsconfig@1.0.0 🚫
Filesystem access npm/path-scurry@1.11.1 🚫
Filesystem access npm/lilconfig@3.1.2 🚫
Environment variable access npm/thread-stream@3.1.0 🚫
Environment variable access npm/minimatch@9.0.5 🚫
Environment variable access npm/minimatch@9.0.5 🚫
Environment variable access npm/jackspeak@3.4.3 🚫
New author npm/safe-regex2@4.0.0 🚫
Shell access npm/foreground-child@3.3.0 🚫
Environment variable access npm/pino@9.4.0 🚫
Environment variable access npm/pino@9.4.0 🚫
Filesystem access npm/chokidar@4.0.1 🚫
Filesystem access npm/chokidar@4.0.1 🚫
Filesystem access npm/chokidar@4.0.1 🚫
Uses eval npm/find-my-way@9.1.0 🚫
Dynamic require npm/tinyexec@0.3.1 🚫
Dynamic require npm/tinyexec@0.3.1 🚫
Environment variable access npm/tinyexec@0.3.1 🚫
Environment variable access npm/tinyexec@0.3.1 🚫
Environment variable access npm/tinyexec@0.3.1 🚫
Environment variable access npm/tinyexec@0.3.1 🚫
Environment variable access npm/tinyexec@0.3.1 🚫
Shell access npm/tinyexec@0.3.1 🚫
Filesystem access npm/fdir@6.4.2 🚫
Uses eval npm/tsup@8.3.4 🚫

View full report↗︎

Next steps

What is environment variable access?

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Packages should be clear about which environment variables they access, and care should be taken to ensure they only access environment variables they claim to.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What are trivial packages?

Packages less than 10 lines of code are easily copied into your own project and may not warrant the additional supply chain risk of an external dependency.

Removing this package as a dependency and implementing its logic will reduce supply chain risk.

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is dynamic code execution?

Package uses dynamic code execution (e.g., eval()), which is a dangerous practice. This can prevent the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use dynamic code execution like eval(), since this could potentially execute any code.

What is dynamic require?

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Packages should avoid dynamic imports when possible. Audit the use of dynamic require to ensure it is not executing malicious or vulnerable code.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/consola@3.2.3
  • @SocketSecurity ignore npm/@ducktors/tsconfig@1.0.0
  • @SocketSecurity ignore npm/path-scurry@1.11.1
  • @SocketSecurity ignore npm/lilconfig@3.1.2
  • @SocketSecurity ignore npm/thread-stream@3.1.0
  • @SocketSecurity ignore npm/minimatch@9.0.5
  • @SocketSecurity ignore npm/jackspeak@3.4.3
  • @SocketSecurity ignore npm/safe-regex2@4.0.0
  • @SocketSecurity ignore npm/foreground-child@3.3.0
  • @SocketSecurity ignore npm/pino@9.4.0
  • @SocketSecurity ignore npm/chokidar@4.0.1
  • @SocketSecurity ignore npm/find-my-way@9.1.0
  • @SocketSecurity ignore npm/tinyexec@0.3.1
  • @SocketSecurity ignore npm/fdir@6.4.2
  • @SocketSecurity ignore npm/tsup@8.3.4

@marco10024 marco10024 force-pushed the feature/update-peer-dependencies branch from 0b04d10 to 401fb71 Compare October 9, 2024 08:58
@mattkrins
Copy link

@alemagio who can merge this?

alemagio
alemagio previously approved these changes Oct 12, 2024
@IvanWei
Copy link

IvanWei commented Oct 19, 2024

@marco10024 @alemagio Fastify v5 will only support Node.js v20+, "CI/Build (18.x" needs remove it.

@pec1985
Copy link

pec1985 commented Dec 9, 2024

Bump

@nelsonacsg
Copy link

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants