Fix more types #969
Fix more types #969
Conversation
| @@ -316,12 +318,12 @@ export interface CreateOfferRequestSlice { | |||
| /** | |||
| * The inclusive time range for the arrival of the slice | |||
| */ | |||
| arrival_time?: string | null | |||
| arrival_time?: TimeRangeFilter | null | |||
There was a problem hiding this comment.
Can we remove the undefined please?
There was a problem hiding this comment.
Do you have to provide these filters though, even as null? From reading the examples on here I didn't think so: https://duffel.com/docs/guides/following-search-best-practices
Below are both valid:
I guess I'm not sure if the sides of the filter can be null, but I can't find the descriptions in the actual API reference.
There was a problem hiding this comment.
The concept of null or undefined to the API is the same I guess. Whether we send the attribute set to null or don't send it at all. But i did notice that when we do redefine or reference some of these types on the dashboard they may mismatch because one side expects undefined to be part of the type vs not. Or some places where we only check if null. Not big deal though if you'd prefer to keep the undefined so we don't need to add to objects when using them.
|
|
||
| /** | ||
| * The inclusive time range for the departure of the slice | ||
| */ | ||
| departure_time?: string | null | ||
| departure_time?: TimeRangeFilter | null |
There was a problem hiding this comment.
[2] Can we remove the undefined please?
andrejak
force-pushed
the
fix-more-types
branch
from
754e0d0 to
a39ea3a
Compare
Fixes issues reported in #936 (guide) and #945.