Immutable rest #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
2 similar comments
|
+1 |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODE REVIEW
This represents the last of the changes required to use the immutable range tree. It'd be awesome to use a common interface for the mutable and immutable rangetree but I'm not sure if that's really possible without generating a lot of cruft (always returning the tree even when it doesn't matter in the mutable case). I just went ahead and exported the ImmutableRangeTree struct and exposed a public constructor. This also adds the apply method and throws in a test that simultaneously reads and writes to an immutable range tree for some piece of mind. I run that test with the race detector on and haven't noticed any issues.
@tannermiller-wf @beaulyddon-wf @alexandercampbell-wf @ericolson-wf @stevenosborne-wf @rosshendrickson-wf @tylertreat-wf