chore(cb2-10273): remove duplicate doc retrieval code #54
Conversation
|
Hi Matt, is it possible to add the following to the .gitIgnore file please? As most on the DVSA side use Webstorm so that directory is being tracked when running locally. |
| const isPlate = plateSerialNumber && !vin && !testNumber && !systemNumber; | ||
| const isLetter = !plateSerialNumber && vin && !testNumber && systemNumber; | ||
|
|
||
| if (isCertificate) { |
There was a problem hiding this comment.
Might be better to have a switch instead
There was a problem hiding this comment.
I generally avoid switches. Any compelling reason to change?
| vinNumber, plateSerialNumber, testNumber, systemNumber, | ||
| } = req.query; | ||
|
|
||
| documentRequestFactory(vinNumber as string, testNumber as string, plateSerialNumber as string, systemNumber as string) |
There was a problem hiding this comment.
Why have you opted for a factory pattern here?
There was a problem hiding this comment.
Each retrieval method should really be a strategy. I used a factory as it's the simplest way to reduce the duplication and I didn't want abstraction leaks in the API tier.
This has already been added @cb-cs 👍 |
Remove duplicate doc retrieval code
Removed duplicate code as per SonarQube report.
CB2-10273
Checklist