Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cb2-11260): update to aws sdk v3 #68

Merged
merged 13 commits into from
Apr 3, 2024
Merged

feat(cb2-11260): update to aws sdk v3 #68

merged 13 commits into from
Apr 3, 2024

Conversation

shivangidas
Copy link
Contributor

@shivangidas shivangidas commented Mar 25, 2024 •
edited
Loading

Upgrade cvs-svc-document-retrieval from AWS SDK v2 to v3

CB2-11260

Checklist

  • Code has been tested manually
  • PR title includes the JIRA ticket number
  • Branch is rebased against the latest develop
  • Squashed commit contains the JIRA ticket number

@shivangidas shivangidas mentioned this pull request Apr 2, 2024
Closed
@shivangidas shivangidas marked this pull request as ready for review April 2, 2024 10:57
@shivangidas shivangidas changed the title feat(cb2-11260): update to aws v3 feat(cb2-11260): update to aws sdk v3 Apr 2, 2024
@shivangidas shivangidas requested review from cb-cs and naathanbrown and removed request for cb-cs April 3, 2024 09:53
naathanbrown
naathanbrown previously approved these changes Apr 3, 2024
View reviewed changes
owen-corrigan
owen-corrigan previously approved these changes Apr 3, 2024
View reviewed changes
JunYanBJSS
JunYanBJSS previously approved these changes Apr 3, 2024
View reviewed changes
@cb-cs
Copy link
Contributor

cb-cs commented Apr 3, 2024

@shivangidas - is there a nack to running this locally and hitting through Postman? When trying to hit on my machine I am getting the following error:

The folder name is not in an environment variable

Are you using an env file after this refactor?

@shivangidas shivangidas merged commit 9ccf0ad into develop Apr 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-corrigan owen-corrigan owen-corrigan approved these changes

@cb-cs cb-cs cb-cs approved these changes

@JunYanBJSS JunYanBJSS JunYanBJSS left review comments

@naathanbrown naathanbrown naathanbrown left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shivangidas @cb-cs @naathanbrown @owen-corrigan @JunYanBJSS