Skip to content

Commit

Permalink
CB2-10907: Joi version bump (#383) (#401)
Browse files Browse the repository at this point in the history
* feat(cb2-10907): joi version bump & schema changes

* feat(cb2-10907): removed console log

* feat(cb2-10907): fix build after rebase

---------

Co-authored-by: Daniel Searle <84069850+Daniel-Searle@users.noreply.github.com>
Co-authored-by: LGin-BJSS <leo.ginever@bjss.com>
  • Loading branch information
3 people authored Apr 10, 2024
1 parent 3f682b3 commit 508eab1
Show file tree
Hide file tree
Showing 23 changed files with 308 additions and 259 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_hash.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Build hash and deploy to S3
run-name: "${{ github.actor }} - ${{ github.ref_name }} - ${{ github.run_id }} 🚀"
run-name: '${{ github.actor }} - ${{ github.ref_name }} - ${{ github.run_id }} 🚀'

on:
workflow_dispatch:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,3 @@ jobs:
-Dsonar.login=${{ env.SONARQUBE_GHA_TOKEN }} \
-Dsonar.projectName=${{ github.repository }} \
-Dsonar.projectVersion=1.0.${{ github.run_id }}
111 changes: 56 additions & 55 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@types/aws-lambda": "^8.10.109",
"@types/jest": "^24.0.21",
"@types/jest-plugin-context": "^2.9.2",
"@types/joi": "^14.3.3",
"@types/joi": "^17.2.3",
"@types/lodash": "^4.14.144",
"@types/node": "^14.18.33",
"@types/sinon": "^7.0.13",
Expand Down Expand Up @@ -83,7 +83,7 @@
"aws-lambda": "^1.0.7",
"aws-sdk": "^2.1354.0",
"aws-xray-sdk": "^3.3.4",
"joi": "^14.3.1",
"joi": "^17.12.1",
"js-yaml": "^3.14.1",
"lodash": "^4.17.21",
"moment": "^2.29.4",
Expand Down
10 changes: 5 additions & 5 deletions src/assets/Enums.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@ export enum ERRORS {

export enum TESTING_ERRORS {
NoDeficiencyCategory = '/location/deficiencyText/stdForProhibition are null for a defect with deficiency category other than advisory',
FuelTypeInvalid = '"fuelType" must be one of [diesel, gas-cng, gas-lng, gas-lpg, petrol, fuel cell, full electric, null]',
ModTypeDescriptionInvalid = '"description" must be one of [particulate trap, modification or change of engine, gas engine]',
EmissionStandardInvalid = '"emissionStandard" must be one of [0.10 g/kWh Euro 3 PM, 0.03 g/kWh Euro IV PM, Euro 3, Euro 4, Euro 5, Euro 6, Euro V, Euro VI, Full Electric, null]',
FuelTypeInvalid = '"testTypes[0].fuelType" must be one of [diesel, gas-cng, gas-lng, gas-lpg, petrol, fuel cell, full electric, null]',
ModTypeDescriptionInvalid = '"testTypes[0].modType.description" must be one of [particulate trap, modification or change of engine, gas engine]',
EmissionStandardInvalid = '"testTypes[0].emissionStandard" must be one of [0.10 g/kWh Euro 3 PM, 0.03 g/kWh Euro IV PM, Euro 3, Euro 4, Euro 5, Euro 6, Euro V, Euro VI, Full Electric, null]',
ModTypeCodeInvalid = '"code" must be one of [p, m, g]',
VehicleSubclassIsNotAllowed = '"vehicleSubclass" is not allowed',
VehicleSubclassIsRequired = '"vehicleSubclass" is required',
EuVehicleCategoryMustBeOneOf = '"euVehicleCategory" must be one of [m1, null]',
VehicleClassIsRequired = '"vehicleClass" is required',
VehicleClassCodeIsInvalid = '"code" must be one of [1, 2, 3, n, s, t, l, v, 4, 5, 7, p, u]',
VehicleClassInvalid = '"vehicleClass" must be an object',
VehicleClassCodeIsInvalid = '"vehicleClass.code" must be one of [1, 2, 3, n, s, t, l, v, 4, 5, 7, p, u]',
VehicleClassInvalid = '"vehicleClass" must be of type object',
}

export enum HTTPRESPONSE {
Expand Down
Loading

0 comments on commit 508eab1

Please sign in to comment.