Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cb2-11271): upgrade cvs-svc-test-results from aws sdk v2 to v3 #406

Merged
merged 12 commits into from
May 20, 2024

Conversation

owen-corrigan
Copy link
Contributor

@owen-corrigan owen-corrigan commented May 15, 2024

Upgrade cvs-svc-test-results from AWS SDK v2 to v3

One line description

resolves issue with sending 400 and incorrect error message for creating a duplicate testId

reformats the errors for get database methods so they'll return usefully and with correct error codes.

Ignores put method errors as they all default to 500 code with the message which remains the same in aws-sdk v3

[link to ticket number](https://dvsa.atlassian.net/browse/CB2-11271)

Checklist

  • Code has been tested manually
  • PR title includes the JIRA ticket number
  • Branch is rebased against the latest develop
  • Squashed commit contains the JIRA ticket number

@owen-corrigan owen-corrigan changed the title Feature/cb2 11271 chore(cb2-11271): upgrade cvs-svc-test-results from aws sdk v2 to v3 May 15, 2024
@owen-corrigan owen-corrigan self-assigned this May 17, 2024
@owen-corrigan owen-corrigan added the dependencies Pull requests that update a dependency file label May 17, 2024
@owen-corrigan owen-corrigan marked this pull request as ready for review May 17, 2024 10:57
@owen-corrigan owen-corrigan merged commit 77ce73a into develop May 20, 2024
4 checks passed
@owen-corrigan owen-corrigan deleted the feature/CB2-11271 branch May 20, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants