Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cb2-12307): refactor cert gen #169

Open
wants to merge 92 commits into
base: develop
Choose a base branch
from
Open

Conversation

me-matt
Copy link
Contributor

@me-matt me-matt commented May 22, 2024

Refactor the cert gen service with design patterns

Refactors a lot of the code in cert gen for readability. Standardises some of the implementations to the dvsa e.g. linting, build process, sonar etc.

Fixes serverless framework for local development.

Removes the any usage for all types throughout the repository.

Improves code structure with repositories and commands for certificate generation.

CB2-12307

Checklist

  • Branch is rebased against the latest develop/common
  • Necessary id required prepended with "test-" have been checked with automation testers and added
  • Code and UI has been tested manually after the additional changes
  • PR title includes the JIRA ticket number
  • Squashed commits contain the JIRA ticket number
  • Link to the PR added to the repo
  • Delete branch after merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant