Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cb2-12580): add cert-gen-init logic and types refactor #202

Merged
merged 16 commits into from
Dec 11, 2024
Merged

feat(cb2-12580): add cert-gen-init logic and types refactor #202

merged 16 commits into from
Dec 11, 2024

Conversation

naathanbrown
Copy link
Contributor

Ticket title

Cert gen init has been removed. Now using the SNS. Refactor the types.
https://dvsa.atlassian.net/browse/CB2-12580

Checklist

  • Branch is rebased against the latest develop/common
  • Necessary id required prepended with "test-" have been checked with automation testers and added
  • Code and UI has been tested manually after the additional changes
  • PR title includes the JIRA ticket number
  • Squashed commits contain the JIRA ticket number
  • Link to the PR added to the repo
  • Delete branch after merge

@naathanbrown naathanbrown marked this pull request as ready for review November 29, 2024 13:38
m-mullen
m-mullen previously approved these changes Dec 3, 2024
View reviewed changes
cb-cs
cb-cs previously approved these changes Dec 4, 2024
View reviewed changes
@cb-cs cb-cs requested a review from m-mullen December 4, 2024 08:27
m-mullen
m-mullen previously approved these changes Dec 4, 2024
View reviewed changes
@naathanbrown naathanbrown dismissed stale reviews from m-mullen and cb-cs via ae2aee4 December 5, 2024 11:28
cb-cs
cb-cs previously approved these changes Dec 6, 2024
View reviewed changes
m-mullen
m-mullen previously approved these changes Dec 6, 2024
View reviewed changes
@naathanbrown naathanbrown dismissed stale reviews from m-mullen and cb-cs via ed01238 December 9, 2024 09:45
cb-cs
cb-cs previously approved these changes Dec 9, 2024
View reviewed changes
@cb-cs cb-cs requested review from m-mullen and cb-cs December 9, 2024 10:08
m-mullen
m-mullen previously approved these changes Dec 9, 2024
View reviewed changes
@naathanbrown naathanbrown dismissed stale reviews from m-mullen and cb-cs via 3062a89 December 9, 2024 12:02
@cb-cs cb-cs merged commit 6a3087e into develop Dec 11, 2024
7 checks passed
@cb-cs cb-cs deleted the feature/CB2-12580 branch December 11, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb-cs cb-cs cb-cs approved these changes

@matthew2564 matthew2564 matthew2564 approved these changes

@m-mullen m-mullen m-mullen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@naathanbrown @matthew2564 @cb-cs @m-mullen