Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): vitals env to exist even if set to off #117

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix(ecs): vitals env to exist even if set to off #117

merged 1 commit into from
Oct 29, 2024

Conversation

odunlop
Copy link
Contributor

@odunlop odunlop commented Oct 28, 2024 •
edited
Loading

Changes:

  • Updates vitals logic so KONG_VITALS environment variable is always explicitly set even if set to off
  • If vitals are turned off, KONG_VITALS_TSDB_ADDRESS is also removed (while preserving option for using KONG_VITALS_TSDB_ADDRESS outside of Prometheus integration established in PR feat: allow setting Vitals TSDB address #104
  • Add validation so only the two valid options of "on" or "off" can be provided for KONG_VITALS

@github-actions GitHub Actions
Copy link

kics-logo

KICS version: v1.5.15

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 1
INFO INFO 12
TRACE TRACE 0
TOTAL TOTAL 13
Metric Values
Files scanned placeholder 21
Files parsed placeholder 21
Files failed to scan placeholder 0
Total executed queries placeholder 1036
Queries failed to execute placeholder 0
Execution time placeholder 20

@odunlop odunlop force-pushed the fix/vitals-enabled branch 4 times, most recently from 8a57bbc to afe6a86 Compare October 29, 2024 13:49
@odunlop
fix(ecs): vitals env to exist even if set to off
1eaf6fa 
Signed-off-by: Orla Dunlop <orla.dunlop@engineering.digital.dwp.gov.uk>
@odunlop odunlop force-pushed the fix/vitals-enabled branch from afe6a86 to 1eaf6fa Compare October 29, 2024 13:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odunlop odunlop merged commit 0ef2ba7 into main Oct 29, 2024
3 checks passed
@odunlop odunlop deleted the fix/vitals-enabled branch October 29, 2024 14:27
odunlop added a commit that referenced this pull request Dec 2, 2024
@odunlop
fix(ecs): vitals env to exist even if set to off (#117)
4f65447 
Signed-off-by: Orla Dunlop <orla.dunlop@engineering.digital.dwp.gov.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahGray3 SarahGray3 SarahGray3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odunlop @SarahGray3