Skip to content

Commit

Permalink
ci: fix bundle size job not working on external PRs
Browse files Browse the repository at this point in the history
  • Loading branch information
dyc3 committed Aug 31, 2024
1 parent a14c4f0 commit ae98285
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/bundle-size.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
matrix:
node-version: [18.x]
ref:
- ${{ github.event.pull_request.base.ref }}
- ${{ github.event.pull_request.head.ref }}
- ${{ github.event.pull_request.base.sha }}
- ${{ github.event.pull_request.head.sha }}
fail-fast: true
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -63,12 +63,12 @@ jobs:
- name: Download bundle size (base ref)
uses: actions/download-artifact@v4
with:
name: bundle-size-${{ github.event.pull_request.base.ref }}
name: bundle-size-${{ github.event.pull_request.base.sha }}
path: /tmp/bundle-size-base.txt
- name: Download bundle size (head ref)
uses: actions/download-artifact@v4
with:
name: bundle-size-${{ github.event.pull_request.head.ref }}
name: bundle-size-${{ github.event.pull_request.head.sha }}
path: /tmp/bundle-size-head.txt
- name: Compare bundle sizes
run: |
Expand Down

0 comments on commit ae98285

Please sign in to comment.