Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typeshare #1103

Merged
merged 10 commits into from
Oct 13, 2023
Merged

add typeshare #1103

merged 10 commits into from
Oct 13, 2023

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Oct 11, 2023

  • add typeshare to deps, add codegen script
  • ci: add check for codegen
  • run lint after codegen
  • refactor how M2B and B2M messages are defined for easier typeshare
  • more refactors
  • more refactors

closes #1099

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1103 (1fe20d8) into master (8c36557) will increase coverage by 1.2747%.
Report is 1 commits behind head on master.
The diff coverage is 0.0000%.

❗ Current head 1fe20d8 differs from pull request most recent head 54aab73. Consider uploading reports for the commit 54aab73 to get more accurate results

@@               Coverage Diff                @@
##             master      #1103        +/-   ##
================================================
+ Coverage   59.6600%   60.9348%   +1.2747%     
================================================
  Files           114        115         +1     
  Lines          9472       8194      -1278     
  Branches       1127       1128         +1     
================================================
- Hits           5651       4993       -658     
+ Misses         3821       3201       -620     
Files Coverage Δ
server/balancer.ts 15.9722% <0.0000%> (ø)
server/generated.ts 0.0000% <0.0000%> (ø)

... and 3 files with indirect coverage changes

@cypress
Copy link

cypress bot commented Oct 11, 2023

2 failed tests on run #636 ↗︎

2 64 0 0 Flakiness 0

Details:

Merge 1fe20d8 into 8c36557...
Project: OpenTogetherTube Commit: 651feb25d8 ℹ️
Status: Failed Duration: 05:04 💡
Started: Oct 12, 2023 8:47 PM Ended: Oct 12, 2023 8:52 PM
Failed  AddPreview.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Output Screenshots Video
Failed  RoomSettingsForm.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Output Screenshots Video

Review all test suite changes for PR #1103 ↗︎

@dyc3 dyc3 added the balancer Improvements or additions to the load balancer label Oct 11, 2023
@dyc3 dyc3 marked this pull request as ready for review October 12, 2023 14:29
@dyc3 dyc3 enabled auto-merge (squash) October 13, 2023 12:30
@dyc3 dyc3 merged commit 074d9bb into master Oct 13, 2023
9 of 12 checks passed
@dyc3 dyc3 deleted the typeshare branch October 13, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
balancer Improvements or additions to the load balancer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use typeshare to share balancer protocol types between balancer and monolith
1 participant