Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another possible fix for flaky component tests #1104

Merged
merged 2 commits into from
Oct 12, 2023
Merged

another possible fix for flaky component tests #1104

merged 2 commits into from
Oct 12, 2023

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Oct 12, 2023

No description provided.

@cypress
Copy link

cypress bot commented Oct 12, 2023

1 failed test on run #631 ↗︎

1 70 1 0 Flakiness 0

Details:

Merge 25fec86 into 9865338...
Project: OpenTogetherTube Commit: 50640a31a7 ℹ️
Status: Failed Duration: 04:46 💡
Started: Oct 12, 2023 4:57 PM Ended: Oct 12, 2023 5:01 PM
Failed  tests/e2e/integration/playback.spec.ts • 1 failed test • E2E - electron

View Output Video

Test Artifacts
Video playback > should add and play a video Output Screenshots Video

Review all test suite changes for PR #1104 ↗︎

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1104 (25fec86) into master (f877e21) will increase coverage by 0.0644%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master      #1104        +/-   ##
================================================
+ Coverage   60.3078%   60.3722%   +0.0644%     
================================================
  Files           114        114                
  Lines          9551       9241       -310     
  Branches       1127       1127                
================================================
- Hits           5760       5579       -181     
+ Misses         3791       3662       -129     

see 1 file with indirect coverage changes

@dyc3 dyc3 merged commit 9520d8f into master Oct 12, 2023
14 of 15 checks passed
@dyc3 dyc3 deleted the fix-e2e-again branch October 12, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant