Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add un/load_room to emulated monoliths #1105

Merged
merged 2 commits into from
Oct 12, 2023
Merged

add un/load_room to emulated monoliths #1105

merged 2 commits into from
Oct 12, 2023

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Oct 12, 2023

closes #1095

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1105 (cd44d6a) into master (9520d8f) will increase coverage by 0.5168%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master      #1105        +/-   ##
================================================
+ Coverage   59.7339%   60.2507%   +0.5168%     
================================================
  Files           114        114                
  Lines          9472       9331       -141     
  Branches       1127       1127                
================================================
- Hits           5658       5622        -36     
+ Misses         3814       3709       -105     

see 4 files with indirect coverage changes

@cypress
Copy link

cypress bot commented Oct 12, 2023

2 failed tests on run #634 ↗︎

2 64 1 0 Flakiness 0

Details:

Merge cd44d6a into 9520d8f...
Project: OpenTogetherTube Commit: 11ee3421d6 ℹ️
Status: Failed Duration: 05:03 💡
Started: Oct 12, 2023 7:57 PM Ended: Oct 12, 2023 8:02 PM
Failed  client/tests/e2e/component/ClickToEdit.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Output Screenshots Video
Failed  tests/e2e/integration/playback.spec.ts • 1 failed test • E2E - electron

View Output Video

Test Artifacts
Video playback > should add and play a video Output Screenshots Video

Review all test suite changes for PR #1105 ↗︎

@dyc3 dyc3 merged commit 8c36557 into master Oct 12, 2023
@dyc3 dyc3 deleted the emu-load-unload branch October 12, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add methods to load and unload rooms on emulated monoliths
1 participant