Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config options to disable room creation #1111

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Oct 21, 2023

No description provided.

@dyc3 dyc3 enabled auto-merge (squash) October 21, 2023 17:31
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #1111 (a09f678) into master (cf1b5fc) will decrease coverage by 0.3468%.
The diff coverage is 100.0000%.

@@               Coverage Diff                @@
##             master      #1111        +/-   ##
================================================
- Coverage   60.9512%   60.6044%   -0.3468%     
================================================
  Files           115        115                
  Lines          8200       9397      +1197     
  Branches       1129       1133         +4     
================================================
+ Hits           4998       5695       +697     
- Misses         3202       3702       +500     
Files Coverage Δ
server/api/room.ts 42.8015% <100.0000%> (+3.9351%) ⬆️
server/ott-config.ts 50.0000% <ø> (ø)

... and 5 files with indirect coverage changes

@cypress
Copy link

cypress bot commented Oct 21, 2023

Passing run #653 ↗︎

0 67 1 1 Flakiness 0

Details:

Merge a09f678 into cf1b5fc...
Project: OpenTogetherTube Commit: 80deb5d608 ℹ️
Status: Passed Duration: 04:13 💡
Started: Oct 21, 2023 5:32 PM Ended: Oct 21, 2023 5:36 PM

Review all test suite changes for PR #1111 ↗︎

@dyc3 dyc3 mentioned this pull request Oct 21, 2023
3 tasks
@dyc3 dyc3 disabled auto-merge October 21, 2023 20:14
@dyc3
Copy link
Owner Author

dyc3 commented Oct 21, 2023

Force merging as test failures are unrelated.

@dyc3 dyc3 merged commit f96fe12 into master Oct 21, 2023
@dyc3 dyc3 deleted the config-room-create branch October 21, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant