fix join race again #1116
Closed
fix join race again #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 failed tests on run #676 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Output
Screenshots
Video
|
|
client/tests/e2e/component/ClickToEdit.cy.ts • 1 failed test • Component - electron
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Output
Screenshots
Video
|
|
client/tests/e2e/component/ShareInvite.cy.ts • 1 failed test • Component - electron
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Output
Screenshots
Video
|
|
tests/e2e/integration/playback.spec.ts • 1 failed test • E2E - electron
| Test | Artifacts | |
|---|---|---|
| Video playback > should add and play a video |
Output
Screenshots
Video
|
|
Review all test suite changes for PR #1116 ↗︎
Codecov Report
@@ Coverage Diff @@
## master #1116 +/- ##
================================================
- Coverage 60.4290% 60.4202% -0.0088%
================================================
Files 115 115
Lines 9277 9280 +3
Branches 1130 1131 +1
================================================
+ Hits 5606 5607 +1
- Misses 3671 3673 +2 |
…lling state i think i figured it out
|
I'm not entirely convinced this complexity is necessary considering what actual user traffic is going to look like. I think that attempting to join a room at the same time it's being loaded is going to be extremely rare. |
auto-merge was automatically disabled
December 8, 2023 21:47
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
route_ws_to_correct_monolith_racecloses #1101 again, hopefully for the last time