Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow balancers to unload rooms #1119

Merged
merged 4 commits into from
Oct 26, 2023
Merged

allow balancers to unload rooms #1119

merged 4 commits into from
Oct 26, 2023

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Oct 26, 2023

  • add B2MUnload
  • refactor how balancer messages are handled

closes #1117

dyc3 added 2 commits October 26, 2023 12:54
makes it so that failure to handle an enum variant produces an error at compile time
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1119 (86f807e) into master (1c46815) will decrease coverage by 0.0629%.
The diff coverage is 0.0000%.

@@               Coverage Diff                @@
##             master      #1119        +/-   ##
================================================
- Coverage   59.7810%   59.7181%   -0.0629%     
================================================
  Files           115        115                
  Lines          9498       9508        +10     
  Branches       1133       1130         -3     
================================================
  Hits           5678       5678                
- Misses         3820       3830        +10     
Files Coverage Δ
server/generated.ts 0.0000% <ø> (ø)
server/clientmanager.ts 21.4574% <0.0000%> (-0.9054%) ⬇️

@cypress
Copy link

cypress bot commented Oct 26, 2023

2 failed tests on run #667 ↗︎

2 63 1 0 Flakiness 0

Details:

Merge 86f807e into 1c46815...
Project: OpenTogetherTube Commit: 9fdabce024 ℹ️
Status: Failed Duration: 05:03 💡
Started: Oct 26, 2023 5:11 PM Ended: Oct 26, 2023 5:16 PM
Failed  RoomSettingsForm.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Output Screenshots Video
Failed  ShareInvite.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Output Screenshots Video

Review all test suite changes for PR #1119 ↗︎

@dyc3 dyc3 merged commit e908dd4 into master Oct 26, 2023
12 of 15 checks passed
@dyc3 dyc3 deleted the b2m-unload branch October 26, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow balancers to force monoliths to unload rooms
2 participants