harness: keep track of client ids in emulated monoliths #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1128 +/- ##
================================================
- Coverage 60.4290% 60.0701% -0.3589%
================================================
Files 115 115
Lines 9277 9121 -156
Branches 1130 1130
================================================
- Hits 5606 5479 -127
+ Misses 3671 3642 -29 |
dyc3
force-pushed
the
harness-client-ids
branch
from
572eabb to
4a42277
Compare
2 failed tests on run #674 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Output
Screenshots
Video
|
|
ShareInvite.cy.ts • 1 failed test • Component - electron
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Output
Screenshots
Video
|
|
Review all test suite changes for PR #1128 ↗︎
cjrkoa
reviewed
Nov 6, 2023
| MsgB2M::Leave(leave) => { | ||
| state.clients.remove(&leave.client); | ||
| }, | ||
| _ => {}, |
There was a problem hiding this comment.
does this mean if anything else finds its way here nothing happens?
cjrkoa
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should help with #1112