Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region config #1148

Closed
wants to merge 10 commits into from
Closed

Add region config #1148

wants to merge 10 commits into from

Conversation

cjrkoa
Copy link
Contributor

@cjrkoa cjrkoa commented Dec 2, 2023

Fixes #1127
Wasn't sure how to approach, not sure where to go from here, also not sure how this ended up here

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2037207) 61.0239% compared to head (40f54bc) 60.5342%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1148        +/-   ##
================================================
- Coverage   61.0239%   60.5342%   -0.4898%     
================================================
  Files           115        115                
  Lines          8223       9322      +1099     
  Branches       1131       1132         +1     
================================================
+ Hits           5018       5643       +625     
- Misses         3205       3679       +474     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyc3
Copy link
Owner

dyc3 commented Dec 3, 2023

You probably forgot to base this branch off of master

@cjrkoa cjrkoa closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

harness: add region to emulated monoliths
2 participants