-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add biomejs, config to do formatting only #1350
base: master
Are you sure you want to change the base?
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1350 +/- ##
===========================================
Coverage ? 56.0442%
===========================================
Files ? 162
Lines ? 24759
Branches ? 1423
===========================================
Hits ? 13876
Misses ? 10829
Partials ? 54 ☔ View full report in Codecov by Sentry. |
Passing run #1979 ↗︎
Details:
Review all test suite changes for PR #1350 ↗︎ |
Bundle size diffdiff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt 2024-05-11 11:50:27.792506751 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt 2024-05-11 11:50:28.388505653 +0000
@@ -1,6 +1,6 @@
-�[36mvite v5.2.8 �[32mbuilding for production...�[36m�[39m
+�[36mvite v5.2.11 �[32mbuilding for production...�[36m�[39m
transforming...
-�[32m✓�[39m 811 modules transformed.
+�[32m✓�[39m 832 modules transformed.
rendering chunks...
computing gzip size...
�[2mdist/�[22m�[32mindex.html �[39m�[1m�[2m 0.90 kB�[22m�[1m�[22m�[2m │ gzip: 0.52 kB�[22m
@@ -25,7 +25,7 @@
�[2mdist/�[22m�[2massets/�[22m�[35mHome-hash.css �[39m�[1m�[2m 0.93 kB�[22m�[1m�[22m�[2m │ gzip: 0.39 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mRoom-hash.css �[39m�[1m�[2m 12.25 kB�[22m�[1m�[22m�[2m │ gzip: 2.93 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mPlyrPlayer-hash.css �[39m�[1m�[2m 30.56 kB�[22m�[1m�[22m�[2m │ gzip: 4.79 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[35mindex-hash.css �[39m�[1m�[2m 367.61 kB�[22m�[1m�[22m�[2m │ gzip: 58.53 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[35mindex-hash.css �[39m�[1m�[2m 376.76 kB�[22m�[1m�[22m�[2m │ gzip: 59.81 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mpirate-hash.js �[39m�[1m�[2m 0.32 kB�[22m�[1m�[22m�[2m │ gzip: 0.25 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mAttribution-hash.js �[39m�[1m�[2m 0.34 kB�[22m�[1m�[22m�[2m │ gzip: 0.26 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mNotFound-hash.js �[39m�[1m�[2m 0.60 kB�[22m�[1m�[22m�[2m │ gzip: 0.32 kB�[22m
@@ -36,13 +36,13 @@
�[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js �[39m�[1m�[2m 5.43 kB�[22m�[1m�[22m�[2m │ gzip: 1.34 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mYoutubePlayer-hash.js �[39m�[1m�[2m 5.86 kB�[22m�[1m�[22m�[2m │ gzip: 2.22 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mde-hash.js �[39m�[1m�[2m 10.79 kB�[22m�[1m�[22m�[2m │ gzip: 4.49 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.79 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.78 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js �[39m�[1m�[2m 12.40 kB�[22m�[1m�[22m�[2m │ gzip: 6.42 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.97 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js �[39m�[1m�[2m 16.35 kB�[22m�[1m�[22m�[2m │ gzip: 5.54 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.99 kB�[22m�[1m�[22m�[2m │ gzip: 12.53 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 164.14 kB�[22m�[1m�[22m�[2m │ gzip: 51.46 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js �[39m�[1m�[33m 604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.36 kB�[22m
-�[32m✓ built in 25.19s�[39m
+�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.95 kB�[22m�[1m�[22m�[2m │ gzip: 12.51 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 163.98 kB�[22m�[1m�[22m�[2m │ gzip: 51.39 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js �[39m�[1m�[33m 604.68 kB�[39m�[22m�[2m │ gzip: 173.48 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 767.93 kB�[39m�[22m�[2m │ gzip: 255.43 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.51 kB�[39m�[22m�[2m │ gzip: 379.29 kB�[22m
+�[32m✓ built in 26.23s�[39m |
Experimenting with switching over to biome from prettier for code formatting. So far, it's looking pretty good. Biome is much faster than prettier, and can format the entire codebase about 800ms.
Some blockers: