Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add biomejs, config to do formatting only #1350

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Feb 18, 2024

Experimenting with switching over to biome from prettier for code formatting. So far, it's looking pretty good. Biome is much faster than prettier, and can format the entire codebase about 800ms.

Some blockers:

  • Only partial support for css
  • No support for html
  • As a result, no support for vue sfc
  • No support for yaml

Copy link
Contributor

coderabbitai bot commented Feb 18, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@347b262). Click here to learn what that means.

❗ Current head 49a4003 differs from pull request most recent head cddd2ec. Consider uploading reports for the commit cddd2ec to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             master      #1350   +/-   ##
===========================================
  Coverage          ?   56.0442%           
===========================================
  Files             ?        162           
  Lines             ?      24759           
  Branches          ?       1423           
===========================================
  Hits              ?      13876           
  Misses            ?      10829           
  Partials          ?         54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 18, 2024

Passing run #1979 ↗︎

0 84 1 0 Flakiness 0

Details:

Merge cddd2ec into 347b262...
Project: OpenTogetherTube Commit: 58a7d85c9c ℹ️
Status: Passed Duration: 05:12 💡
Started: May 11, 2024 11:49 AM Ended: May 11, 2024 11:55 AM

Review all test suite changes for PR #1350 ↗︎

@dyc3 dyc3 added the blocked/external Can't complete yet due to external blocker label Feb 18, 2024
Copy link

Bundle size diff

diff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt	2024-05-11 11:50:27.792506751 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt	2024-05-11 11:50:28.388505653 +0000
@@ -1,6 +1,6 @@
-�[36mvite v5.2.8 �[32mbuilding for production...�[36m�[39m
+�[36mvite v5.2.11 �[32mbuilding for production...�[36m�[39m
 transforming...
-�[32m✓�[39m 811 modules transformed.
+�[32m✓�[39m 832 modules transformed.
 rendering chunks...
 computing gzip size...
 �[2mdist/�[22m�[32mindex.html                                            �[39m�[1m�[2m    0.90 kB�[22m�[1m�[22m�[2m │ gzip:   0.52 kB�[22m
@@ -25,7 +25,7 @@
 �[2mdist/�[22m�[2massets/�[22m�[35mHome-hash.css                              �[39m�[1m�[2m    0.93 kB�[22m�[1m�[22m�[2m │ gzip:   0.39 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[35mRoom-hash.css                              �[39m�[1m�[2m   12.25 kB�[22m�[1m�[22m�[2m │ gzip:   2.93 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[35mPlyrPlayer-hash.css                        �[39m�[1m�[2m   30.56 kB�[22m�[1m�[22m�[2m │ gzip:   4.79 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[35mindex-hash.css                             �[39m�[1m�[2m  367.61 kB�[22m�[1m�[22m�[2m │ gzip:  58.53 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[35mindex-hash.css                             �[39m�[1m�[2m  376.76 kB�[22m�[1m�[22m�[2m │ gzip:  59.81 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mpirate-hash.js                             �[39m�[1m�[2m    0.32 kB�[22m�[1m�[22m�[2m │ gzip:   0.25 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mAttribution-hash.js                        �[39m�[1m�[2m    0.34 kB�[22m�[1m�[22m�[2m │ gzip:   0.26 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mNotFound-hash.js                           �[39m�[1m�[2m    0.60 kB�[22m�[1m�[22m�[2m │ gzip:   0.32 kB�[22m
@@ -36,13 +36,13 @@
 �[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js                               �[39m�[1m�[2m    5.43 kB�[22m�[1m�[22m�[2m │ gzip:   1.34 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mYoutubePlayer-hash.js                      �[39m�[1m�[2m    5.86 kB�[22m�[1m�[22m�[2m │ gzip:   2.22 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mde-hash.js                                 �[39m�[1m�[2m   10.79 kB�[22m�[1m�[22m�[2m │ gzip:   4.49 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js                                 �[39m�[1m�[2m   11.59 kB�[22m�[1m�[22m�[2m │ gzip:   4.79 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js                                 �[39m�[1m�[2m   11.59 kB�[22m�[1m�[22m�[2m │ gzip:   4.78 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js                                 �[39m�[1m�[2m   12.40 kB�[22m�[1m�[22m�[2m │ gzip:   6.42 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js                                 �[39m�[1m�[2m   14.05 kB�[22m�[1m�[22m�[2m │ gzip:   5.97 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js                     �[39m�[1m�[2m   16.35 kB�[22m�[1m�[22m�[2m │ gzip:   5.54 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js                        �[39m�[1m�[2m   39.99 kB�[22m�[1m�[22m�[2m │ gzip:  12.53 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js                               �[39m�[1m�[2m  164.14 kB�[22m�[1m�[22m�[2m │ gzip:  51.46 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js                  �[39m�[1m�[33m  604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js                              �[39m�[1m�[33m  743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js                         �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.36 kB�[22m
-�[32m✓ built in 25.19s�[39m
+�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js                        �[39m�[1m�[2m   39.95 kB�[22m�[1m�[22m�[2m │ gzip:  12.51 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js                               �[39m�[1m�[2m  163.98 kB�[22m�[1m�[22m�[2m │ gzip:  51.39 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js                  �[39m�[1m�[33m  604.68 kB�[39m�[22m�[2m │ gzip: 173.48 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js                              �[39m�[1m�[33m  767.93 kB�[39m�[22m�[2m │ gzip: 255.43 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js                         �[39m�[1m�[33m1,280.51 kB�[39m�[22m�[2m │ gzip: 379.29 kB�[22m
+�[32m✓ built in 26.23s�[39m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/external Can't complete yet due to external blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant