Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RU locale update #1782

Merged
merged 1 commit into from
Jul 1, 2024
Merged

RU locale update #1782

merged 1 commit into from
Jul 1, 2024

Conversation

SabatonShip
Copy link
Contributor

Added and translated new strings from en.ts
Improved old translates

@SabatonShip SabatonShip requested a review from dyc3 as a code owner July 1, 2024 16:32
@SabatonShip SabatonShip marked this pull request as draft July 1, 2024 16:37
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 117 lines in your changes missing coverage. Please review.

Project coverage is 62.6440%. Comparing base (7adc1b0) to head (24f30ff).

Files Patch % Lines
client/src/locales/ru.ts 0.0000% 116 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1782        +/-   ##
================================================
- Coverage   62.8220%   62.6440%   -0.1781%     
================================================
  Files           168        168                
  Lines         24918      24992        +74     
  Branches       1441       1444         +3     
================================================
+ Hits          15654      15656         +2     
- Misses         9211       9283        +72     
  Partials         53         53                

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@SabatonShip
Copy link
Contributor Author

Thanks for the update!

Hey! No problem! Please wait, I'll try install yarn...

@SabatonShip
Copy link
Contributor Author

Okay, so... I fixed the lint, but what about the failures in other tests? I don't understand...

@SabatonShip
Copy link
Contributor Author

Wait, and now it passed... Interesting...

@SabatonShip SabatonShip marked this pull request as ready for review July 1, 2024 17:50
@SabatonShip SabatonShip requested a review from dyc3 July 1, 2024 17:51
Added and translated new strings from en.ts
Improved old translates
@dyc3
Copy link
Owner

dyc3 commented Jul 1, 2024

Some of the rust tests are a little flakey. Nothing for you to worry about.

@dyc3 dyc3 merged commit 5a57bd5 into dyc3:master Jul 1, 2024
21 of 24 checks passed
Copy link

cypress bot commented Jul 1, 2024

Passing run #1988 ↗︎

0 84 1 0 Flakiness 0

Details:

RU locale update (#1782)
Project: OpenTogetherTube Commit: 5a57bd588b
Status: Passed Duration: 05:20 💡
Started: Jul 1, 2024 11:29 PM Ended: Jul 1, 2024 11:34 PM

Review all test suite changes for PR #1782 ↗︎

@SabatonShip SabatonShip deleted the ru-locale branch July 2, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants