Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the bug report issue template in order to avoid "1 of n tasks" for the environment section #1783

Closed
wants to merge 2 commits into from

Conversation

ceofil
Copy link
Contributor

@ceofil ceofil commented Jul 6, 2024

No description provided.

@ceofil ceofil requested a review from dyc3 as a code owner July 6, 2024 12:33
@dyc3
Copy link
Owner

dyc3 commented Jul 6, 2024

I wish github had a better way to review these changes. Could you enable issues on your fork so I can preview the changes?

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.6278%. Comparing base (c91bbab) to head (3c0abbb).

Additional details and impacted files
@@             Coverage Diff             @@
##             master      #1783   +/-   ##
===========================================
  Coverage   62.6278%   62.6278%           
===========================================
  Files           168        168           
  Lines         25032      25032           
  Branches       1446       1446           
===========================================
  Hits          15677      15677           
  Misses         9302       9302           
  Partials         53         53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ceofil
Copy link
Contributor Author

ceofil commented Jul 6, 2024

I wish github had a better way to review these changes. Could you enable issues on your fork so I can preview the changes?

Me too =))
Also the fact that you have to commit the file in order to see if it works. No preview or anything.
I enabled the issues. :D

Copy link
Owner

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, I don't really like how this doesn't show up as a bullet list when rendered in the issue

Example:
image

attributes:
label: Environment
description: Mark the appropriate boxes. If you don't know if the statement applies, leave it blank.
description: Select the appropriate options. If you don't know if the statement
applies, leave it blank.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
applies, leave it blank.
applies, leave it unselected.

@ceofil
Copy link
Contributor Author

ceofil commented Jul 6, 2024

Eh, I don't really like how this doesn't show up as a bullet list when rendered in the issue

Example: image

There is also this option https://github.com/orgs/community/discussions/4319#discussioncomment-5942069

@dyc3
Copy link
Owner

dyc3 commented Jul 6, 2024

If you can figure out how to keep those options in a list, and have it not show up with "1 of n tasks" in the github UI, I'll happily merge this, but tbh it's not that big of a deal, and probably not worth the effort.

@ceofil ceofil closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants