Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only render privacy policy on official site #1789

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Aug 22, 2024

No description provided.

Copy link
Owner Author

dyc3 commented Aug 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dyc3 and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Aug 22, 2024

Bundle size diff

diff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt	2024-08-22 16:57:14.248725696 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt	2024-08-22 16:57:14.864730019 +0000
@@ -1,9 +1,9 @@
 �[36mvite v5.2.8 �[32mbuilding for production...�[36m�[39m
 transforming...
-�[32m✓�[39m 812 modules transformed.
+�[32m✓�[39m 813 modules transformed.
 rendering chunks...
 computing gzip size...
-�[2mdist/�[22m�[32mindex.html                                            �[39m�[1m�[2m    0.90 kB�[22m�[1m�[22m�[2m │ gzip:   0.52 kB�[22m
+�[2mdist/�[22m�[32mindex.html                                            �[39m�[1m�[2m    0.90 kB�[22m�[1m�[22m�[2m │ gzip:   0.53 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[32mpop-hash.ogg                               �[39m�[1m�[2m    6.63 kB�[22m�[1m�[22m
 �[2mdist/�[22m�[2massets/�[22m�[32mroboto-hash.woff2         �[39m�[1m�[2m    9.63 kB�[22m�[1m�[22m
 �[2mdist/�[22m�[2massets/�[22m�[32mroboto-hash.woff2            �[39m�[1m�[2m    9.64 kB�[22m�[1m�[22m
@@ -19,6 +19,7 @@
 �[2mdist/�[22m�[2massets/�[22m�[32mmaterialdesignicons-hash.eot       �[39m�[1m�[2m  663.15 kB�[22m�[1m�[22m
 �[2mdist/�[22m�[2massets/�[22m�[35mNotFound-hash.css                          �[39m�[1m�[2m    0.03 kB�[22m�[1m�[22m�[2m │ gzip:   0.05 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[35mVimeoPlayer-hash.css                       �[39m�[1m�[2m    0.03 kB�[22m�[1m�[22m�[2m │ gzip:   0.05 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[35mPrivacy-hash.css                           �[39m�[1m�[2m    0.03 kB�[22m�[1m�[22m�[2m │ gzip:   0.05 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[35mGoogleDrivePlayer-hash.css                 �[39m�[1m�[2m    0.11 kB�[22m�[1m�[22m�[2m │ gzip:   0.12 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[35mYoutubePlayer-hash.css                     �[39m�[1m�[2m    0.15 kB�[22m�[1m�[22m�[2m │ gzip:   0.14 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[35mRoomList-hash.css                          �[39m�[1m�[2m    0.31 kB�[22m�[1m�[22m�[2m │ gzip:   0.22 kB�[22m
@@ -32,18 +33,18 @@
 �[2mdist/�[22m�[2massets/�[22m�[36mplaceholder-hash.js                        �[39m�[1m�[2m    1.04 kB�[22m�[1m�[22m�[2m │ gzip:   0.48 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js                      �[39m�[1m�[2m    2.00 kB�[22m�[1m�[22m�[2m │ gzip:   0.95 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mRoomList-hash.js                           �[39m�[1m�[2m    2.31 kB�[22m�[1m�[22m�[2m │ gzip:   1.08 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPrivacy-hash.js                            �[39m�[1m�[2m    2.64 kB�[22m�[1m�[22m�[2m │ gzip:   1.29 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js                               �[39m�[1m�[2m    5.43 kB�[22m�[1m�[22m�[2m │ gzip:   1.34 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPrivacy-hash.js                            �[39m�[1m�[2m    2.94 kB�[22m�[1m�[22m�[2m │ gzip:   1.36 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js                               �[39m�[1m�[2m    5.48 kB�[22m�[1m�[22m�[2m │ gzip:   1.38 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mYoutubePlayer-hash.js                      �[39m�[1m�[2m    5.86 kB�[22m�[1m�[22m�[2m │ gzip:   2.22 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mde-hash.js                                 �[39m�[1m�[2m   10.79 kB�[22m�[1m�[22m�[2m │ gzip:   4.49 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js                                 �[39m�[1m�[2m   11.59 kB�[22m�[1m�[22m�[2m │ gzip:   4.78 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js                                 �[39m�[1m�[2m   13.57 kB�[22m�[1m�[22m�[2m │ gzip:   6.94 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js                                 �[39m�[1m�[2m   11.59 kB�[22m�[1m�[22m�[2m │ gzip:   4.79 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js                                 �[39m�[1m�[2m   13.57 kB�[22m�[1m�[22m�[2m │ gzip:   6.95 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mpt-hash.js                              �[39m�[1m�[2m   13.81 kB�[22m�[1m�[22m�[2m │ gzip:   5.87 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js                                 �[39m�[1m�[2m   14.05 kB�[22m�[1m�[22m�[2m │ gzip:   5.97 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js                                 �[39m�[1m�[2m   14.05 kB�[22m�[1m�[22m�[2m │ gzip:   5.98 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js                     �[39m�[1m�[2m   16.35 kB�[22m�[1m�[22m�[2m │ gzip:   5.54 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js                        �[39m�[1m�[2m   39.99 kB�[22m�[1m�[22m�[2m │ gzip:  12.52 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js                               �[39m�[1m�[2m  164.20 kB�[22m�[1m�[22m�[2m │ gzip:  51.46 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js                  �[39m�[1m�[33m  604.87 kB�[39m�[22m�[2m │ gzip: 173.50 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js                              �[39m�[1m�[33m  743.63 kB�[39m�[22m�[2m │ gzip: 248.21 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js                         �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.36 kB�[22m
-�[32m✓ built in 26.31s�[39m
+�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js                        �[39m�[1m�[2m   39.99 kB�[22m�[1m�[22m�[2m │ gzip:  12.53 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js                               �[39m�[1m�[2m  164.21 kB�[22m�[1m�[22m�[2m │ gzip:  51.46 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js                  �[39m�[1m�[33m  604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js                              �[39m�[1m�[33m  743.90 kB�[39m�[22m�[2m │ gzip: 248.30 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js                         �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.37 kB�[22m
+�[32m✓ built in 27.16s�[39m

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 36 lines in your changes missing coverage. Please review.

Project coverage is 61.5656%. Comparing base (5cba30c) to head (16985ba).
Report is 1 commits behind head on master.

Files Patch % Lines
client/src/views/Privacy.vue 0.0000% 21 Missing ⚠️
client/src/router.ts 0.0000% 10 Missing ⚠️
client/src/util/misc.ts 50.0000% 2 Missing ⚠️
client/src/views/Home.vue 0.0000% 2 Missing ⚠️
client/src/views/Room.vue 80.0000% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1789        +/-   ##
================================================
- Coverage   61.6161%   61.5656%   -0.0506%     
================================================
  Files           169        169                
  Lines         25443      25472        +29     
  Branches       1447       1447                
================================================
+ Hits          15677      15682         +5     
- Misses         9712       9736        +24     
  Partials         54         54                

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Aug 22, 2024



Test summary

83 1 1 0


Run details

Project OpenTogetherTube
Status Failed
Commit fd0abe6 ℹ️
Started Aug 22, 2024 5:05 PM
Ended Aug 22, 2024 5:11 PM
Duration 05:52 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


Failures

tests/e2e/integration/playback.spec.ts Failed
1 Video playback > should add and play a youtube video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@dyc3 dyc3 marked this pull request as ready for review August 22, 2024 16:29
@dyc3 dyc3 force-pushed the 08-22-update_deps_to_fix_rust_builds branch from 0381ed8 to 2673c72 Compare August 22, 2024 16:53
@dyc3 dyc3 force-pushed the 08-22-only_render_privacy_policy_on_official_site branch from e401bb9 to 0b61bb3 Compare August 22, 2024 16:53
@dyc3 dyc3 changed the base branch from 08-22-update_deps_to_fix_rust_builds to graphite-base/1789 August 22, 2024 17:04
@dyc3 dyc3 force-pushed the 08-22-only_render_privacy_policy_on_official_site branch from 0b61bb3 to 16985ba Compare August 22, 2024 17:04
@dyc3 dyc3 changed the base branch from graphite-base/1789 to master August 22, 2024 17:05
@dyc3 dyc3 merged commit cf0a571 into master Aug 22, 2024
16 of 23 checks passed
Copy link
Owner Author

dyc3 commented Aug 22, 2024

Merge activity

  • Aug 22, 1:09 PM EDT: @dyc3 merged this pull request with Graphite.

@dyc3 dyc3 deleted the 08-22-only_render_privacy_policy_on_official_site branch August 22, 2024 17:09
Copy link

cypress bot commented Aug 22, 2024



Test summary

83 1 1 0


Run details

Project OpenTogetherTube
Status Failed
Commit cf0a571
Started Aug 22, 2024 5:10 PM
Ended Aug 22, 2024 5:16 PM
Duration 05:38 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


Failures

tests/e2e/integration/playback.spec.ts Failed
1 Video playback > should add and play a youtube video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

WuTofu pushed a commit to WuTofu/opentogethertube that referenced this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant