client: move chat outside of youtube player bounds to comply with youtube TOS #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Bundle size diffdiff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt 2024-08-22 22:10:47.151694722 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt 2024-08-22 22:10:47.739693032 +0000
@@ -24,7 +24,7 @@
�[2mdist/�[22m�[2massets/�[22m�[35mYoutubePlayer-hash.css �[39m�[1m�[2m 0.15 kB�[22m�[1m�[22m�[2m │ gzip: 0.14 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mRoomList-hash.css �[39m�[1m�[2m 0.31 kB�[22m�[1m�[22m�[2m │ gzip: 0.22 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mHome-hash.css �[39m�[1m�[2m 0.93 kB�[22m�[1m�[22m�[2m │ gzip: 0.39 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[35mRoom-hash.css �[39m�[1m�[2m 12.25 kB�[22m�[1m�[22m�[2m │ gzip: 2.93 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[35mRoom-hash.css �[39m�[1m�[2m 12.55 kB�[22m�[1m�[22m�[2m │ gzip: 2.97 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mPlyrPlayer-hash.css �[39m�[1m�[2m 30.56 kB�[22m�[1m�[22m�[2m │ gzip: 4.79 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mindex-hash.css �[39m�[1m�[2m 367.61 kB�[22m�[1m�[22m�[2m │ gzip: 58.53 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mpirate-hash.js �[39m�[1m�[2m 0.32 kB�[22m�[1m�[22m�[2m │ gzip: 0.25 kB�[22m
@@ -37,14 +37,14 @@
�[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js �[39m�[1m�[2m 5.48 kB�[22m�[1m�[22m�[2m │ gzip: 1.38 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mYoutubePlayer-hash.js �[39m�[1m�[2m 5.86 kB�[22m�[1m�[22m�[2m │ gzip: 2.22 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mde-hash.js �[39m�[1m�[2m 10.79 kB�[22m�[1m�[22m�[2m │ gzip: 4.49 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.79 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js �[39m�[1m�[2m 13.57 kB�[22m�[1m�[22m�[2m │ gzip: 6.95 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.78 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js �[39m�[1m�[2m 13.57 kB�[22m�[1m�[22m�[2m │ gzip: 6.94 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mpt-hash.js �[39m�[1m�[2m 13.81 kB�[22m�[1m�[22m�[2m │ gzip: 5.87 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.98 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.97 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js �[39m�[1m�[2m 16.35 kB�[22m�[1m�[22m�[2m │ gzip: 5.54 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.99 kB�[22m�[1m�[22m�[2m │ gzip: 12.53 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 164.21 kB�[22m�[1m�[22m�[2m │ gzip: 51.46 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.99 kB�[22m�[1m�[22m�[2m │ gzip: 12.52 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 164.27 kB�[22m�[1m�[22m�[2m │ gzip: 51.49 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js �[39m�[1m�[33m 604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 743.90 kB�[39m�[22m�[2m │ gzip: 248.30 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.37 kB�[22m
-�[32m✓ built in 25.62s�[39m
+�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.36 kB�[22m
+�[32m✓ built in 25.34s�[39m |
OpenTogetherTube
|
||||||||||||||||||||||||||||||||||
| Project |
OpenTogetherTube
|
| Branch Review |
08-22-client_move_chat_outside_of_youtube_player_bounds_to_comply_with_youtube_tos
|
| Run status |
|
| Run duration | 05m 37s |
| Commit |
|
| Committer | Carson McManus |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
83
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/e2e/integration/playback.spec.ts • 1 failed test • E2E - electron
| Test | Artifacts | |
|---|---|---|
| Video playback > should add and play a youtube video |
Test Replay
Screenshots
|
|
dyc3
force-pushed
the
08-22-client_move_chat_outside_of_youtube_player_bounds_to_comply_with_youtube_tos
branch
from
c35bb90 to
c81013e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1791 +/- ##
================================================
+ Coverage 61.5656% 61.6003% +0.0346%
================================================
Files 169 169
Lines 25472 25495 +23
Branches 1447 1447
================================================
+ Hits 15682 15705 +23
Misses 9736 9736
Partials 54 54 ☔ View full report in Codecov by Sentry. |
dyc3
force-pushed
the
08-22-client_move_chat_outside_of_youtube_player_bounds_to_comply_with_youtube_tos
branch
from
c81013e to
3212d0a
Compare
dyc3
deleted the
08-22-client_move_chat_outside_of_youtube_player_bounds_to_comply_with_youtube_tos
branch
OpenTogetherTube
|
||||||||||||||||||||||||||||||||||
| Project |
OpenTogetherTube
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 06m 01s |
| Commit |
|
| Committer | Carson McManus |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
1
|
|
Flaky
|
0
|
|
Pending
|
1
|
|
Skipped
|
0
|
|
Passing
|
83
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/e2e/integration/playback.spec.ts • 1 failed test • E2E - electron
| Test | Artifacts | |
|---|---|---|
| Video playback > should add and play a youtube video |
Test Replay
Screenshots
|
|
WuTofu
pushed a commit
to WuTofu/opentogethertube
that referenced
this pull request
Aug 25, 2024
dyc3
added a commit
that referenced
this pull request
Aug 26, 2024
dyc3
added a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.