-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): fix incorrectly specified redirects in router #1809
Merged
dyc3
merged 1 commit into
master
from
10-27-fix_client_fix_incorrectly_specified_redirects_in_router
Oct 27, 2024
Merged
fix(client): fix incorrectly specified redirects in router #1809
dyc3
merged 1 commit into
master
from
10-27-fix_client_fix_incorrectly_specified_redirects_in_router
Oct 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size diffdiff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt 2024-10-27 11:55:18.072928074 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt 2024-10-27 11:55:18.492931462 +0000
@@ -37,13 +37,13 @@
dist/assets/Home-hash.js 5.48 kB │ gzip: 1.38 kB
dist/assets/YoutubePlayer-hash.js 5.48 kB │ gzip: 2.12 kB
dist/assets/de-hash.js 10.79 kB │ gzip: 4.49 kB
-dist/assets/fr-hash.js 11.59 kB │ gzip: 4.79 kB
+dist/assets/fr-hash.js 11.59 kB │ gzip: 4.78 kB
dist/assets/ru-hash.js 13.57 kB │ gzip: 6.94 kB
dist/assets/pt-hash.js 13.81 kB │ gzip: 5.87 kB
-dist/assets/es-hash.js 14.05 kB │ gzip: 5.98 kB
+dist/assets/es-hash.js 14.05 kB │ gzip: 5.97 kB
dist/assets/PeertubePlayer-hash.js 16.35 kB │ gzip: 5.54 kB
dist/assets/VimeoPlayer-hash.js 39.95 kB │ gzip: 12.51 kB
dist/assets/Room-hash.js 164.04 kB │ gzip: 51.42 kB
dist/assets/GoogleDrivePlayer-hash.js 604.60 kB │ gzip: 173.41 kB
-dist/assets/index-hash.js 748.71 kB │ gzip: 250.30 kB
+dist/assets/index-hash.js 748.75 kB │ gzip: 250.28 kB
dist/assets/PlyrPlayer-hash.js 1,280.51 kB │ gzip: 379.29 kB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1809 +/- ##
================================================
- Coverage 61.6489% 61.6271% -0.0218%
================================================
Files 169 169
Lines 25483 25492 +9
Branches 1447 1446 -1
================================================
Hits 15710 15710
- Misses 9719 9728 +9
Partials 54 54 ☔ View full report in Codecov by Sentry. |
dyc3
deleted the
10-27-fix_client_fix_incorrectly_specified_redirects_in_router
branch
October 27, 2024 11:58
OpenTogetherTube Run #2021
Run Properties:
|
Project |
OpenTogetherTube
|
Branch Review |
10-27-fix_client_fix_incorrectly_specified_redirects_in_router
|
Run status |
Failed #2021
|
Run duration | 06m 03s |
Commit |
157c246eda ℹ️: Merge 9a64cebfb6cc0b579a8cb0b1bcbe3389e6c5495e into 1f33f52239c26385eb81d95b96c2...
|
Committer | Carson McManus |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
0
|
Pending |
1
|
Skipped |
0
|
Passing |
83
|
View all changes introduced in this branch ↗︎ |
Tests for review
tests/e2e/integration/playback.spec.ts • 1 failed test • E2E - electron
Test | Artifacts | |
---|---|---|
Video playback > should add and play a youtube video |
Test Replay
Screenshots
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1808