Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted some types and avoided some mongo promise errors by choosing a docker mongo version instead of always picking the latest version #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adjusted some types and avoided some mongo promise errors by choosing a docker mongo version instead of always picking the latest version #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af3704
Update README.md
jamesEmerson112 Sep 27, 2022
008c167
Update README.md
jamesEmerson112 Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 5-Make_Multiple_Containers_Work_Together/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,13 @@ Docker is the only thing you need from now on! So let's get started spinning the

- [ ] Build your results server image and tag it with the name 'results' by running `docker build -t results .`

- [ ] Pull down a MongoDB image by running `docker pull mongo:latest`
- [ ] Pull down a MongoDB image by running `docker pull mongo:4.0`

This saves us a lot of time - since we straight up just need a MongoDB database and don't need to configure it in any way we'll just pull the official image from Dockerhub. As with every other time you used the `docker pull` command it grabs the image from Dockerhub and caches it on your machine. This time is no different. However, the way you spin up the official MongoDB image is a little different than we are used to; let's check it out ->

**Second:** Run the containers:

- [ ] First, we'll spin up the MongoDB container. Run `docker run -d --name mongo mongo:latest`
- [ ] First, we'll spin up the MongoDB container. Run `docker run -d --name mongo mongo:4.0`

You might be wondering, **'Where's the -p port mapping option that we've used EVERY OTHER TIME?!?!?'**

Expand Down
2 changes: 1 addition & 1 deletion 6-Docker_Compose_For_Multi-Container_Apps/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Luckily for you, this problem had already been solved for you before you even kn

- [ ] Rather than spending forever talking about what Docker Compose does and why it's great, let's just dive into a demonstration. `cd` into the directory '/6-Docker_Compose_For_Multi-Container_Apps'

- [ ] Run the command `ls` and notice that we have directories that contain the source code for the services of our polling app from the previous Module (the 'survey_server' and 'results_server'). Each of these directories contains it's own Dockerfile that defines the steps to build it's requisite image. This should all be familiar to you.
- [ ] Run the command `ls` and notice that we have directories that contain the source code for the services of our polling app from the previous Module (the 'survey_server' and 'results_server'). Each of these directories contains its own Dockerfile that defines the steps to build its requisite image. This should all be familiar to you.

- [ ] Also notice that there is a file in Module 6 that you may not be familiar with, the one named 'docker-compose.yml'. We'll dive into this shortly.

Expand Down