fix(rollapp): cli update only metadata (#1708)

fix cli update only rollapp metadata
dymensionxyz · Jan 13, 2025 · 942c868 · 942c868
1 parent 200dd62
commit 942c868
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 15 deletions.
diff --git a/x/rollapp/client/cli/flags.go b/x/rollapp/client/cli/flags.go
@@ -1,7 +1,6 @@
 package cli
 
 import (
-	rollapptypes "github.com/dymensionxyz/dymension/v3/x/rollapp/types"
 	flag "github.com/spf13/pflag"
 )
 
@@ -21,7 +20,7 @@ func FlagSetUpdateRollapp() *flag.FlagSet {
 	fs := flag.NewFlagSet("", flag.ContinueOnError)
 
 	fs.String(FlagInitSequencer, "", "The address of the sequencer that will be used to initialize the rollapp")
-	fs.String(FlagMinSequencerBond, rollapptypes.DefaultMinSequencerBondGlobalCoin.Amount.String(), "Minimum amount of bond required to be a sequencer in DYM (not adym)")
+	fs.String(FlagMinSequencerBond, "", "Minimum amount of bond required to be a sequencer in DYM (not adym)")
 	fs.String(FlagGenesisChecksum, "", "The checksum of the genesis file of the rollapp")
 	fs.String(FlagNativeDenom, "", "The native denomination of the rollapp")
 	fs.String(FlagInitialSupply, "", "The initial supply of the rollapp")

diff --git a/x/rollapp/client/cli/tx_create_rollapp.go b/x/rollapp/client/cli/tx_create_rollapp.go
@@ -8,9 +8,10 @@ import (
 	"github.com/cosmos/cosmos-sdk/client/flags"
 	"github.com/cosmos/cosmos-sdk/client/tx"
 	sdk "github.com/cosmos/cosmos-sdk/types"
-	commontypes "github.com/dymensionxyz/dymension/v3/x/common/types"
 	"github.com/spf13/cobra"
 
+	commontypes "github.com/dymensionxyz/dymension/v3/x/common/types"
+
 	"github.com/dymensionxyz/dymension/v3/utils"
 	"github.com/dymensionxyz/dymension/v3/x/rollapp/types"
 )
@@ -49,6 +50,9 @@ func CmdCreateRollapp() *cobra.Command {
 			if err != nil {
 				return err
 			}
+			if minSeqBondS == "" {
+				minSeqBondS = types.DefaultMinSequencerBondGlobalCoin.Amount.String()
+			}
 			minSeqBond, ok := sdk.NewIntFromString(minSeqBondS)
 			if !ok {
 				return fmt.Errorf("invalid min sequencer bond: %s", minSeqBondS)
@@ -158,11 +162,18 @@ func parseGenesisInfo(cmd *cobra.Command) (*types.GenesisInfo, error) {
 				Amount:  amt,
 			})
 		}
-		genesisInfo.GenesisAccounts = &types.GenesisAccounts{
-			Accounts: accounts,
+		if len(genesisAccounts) > 0 {
+			genesisInfo.GenesisAccounts = &types.GenesisAccounts{
+				Accounts: accounts,
+			}
 		}
 	}
 
+	if genesisInfo.GenesisChecksum == "" && genesisInfo.GenesisAccounts == nil && genesisInfo.Bech32Prefix == "" &&
+		genesisInfo.InitialSupply.IsNil() && genesisInfo.NativeDenom.Base == "" {
+		return nil, nil
+	}
+
 	return genesisInfo, nil
 }
 

diff --git a/x/rollapp/client/cli/tx_update_rollapp.go b/x/rollapp/client/cli/tx_update_rollapp.go
@@ -7,9 +7,10 @@ import (
 	"github.com/cosmos/cosmos-sdk/client/flags"
 	"github.com/cosmos/cosmos-sdk/client/tx"
 	sdk "github.com/cosmos/cosmos-sdk/types"
-	commontypes "github.com/dymensionxyz/dymension/v3/x/common/types"
 	"github.com/spf13/cobra"
 
+	commontypes "github.com/dymensionxyz/dymension/v3/x/common/types"
+
 	"github.com/dymensionxyz/dymension/v3/x/rollapp/types"
 )
 
@@ -39,9 +40,14 @@ func CmdUpdateRollapp() *cobra.Command {
 			if err != nil {
 				return err
 			}
-			minSeqBond, ok := sdk.NewIntFromString(minSeqBondS)
-			if !ok {
-				return fmt.Errorf("invalid min sequencer bond: %s", minSeqBondS)
+
+			var minSeqBondDym sdk.Coin
+			if minSeqBondS != "" {
+				minSeqBond, ok := sdk.NewIntFromString(minSeqBondS)
+				if !ok {
+					return fmt.Errorf("invalid min sequencer bond: %s", minSeqBondS)
+				}
+				minSeqBondDym = commontypes.ADym(minSeqBond)
 			}
 
 			genesisInfo, err := parseGenesisInfo(cmd)
@@ -63,7 +69,7 @@ func CmdUpdateRollapp() *cobra.Command {
 				clientCtx.GetFromAddress().String(),
 				argRollappId,
 				initSequencer,
-				commontypes.ADym(minSeqBond),
+				minSeqBondDym,
 				metadata,
 				genesisInfo,
 			)

diff --git a/x/rollapp/keeper/msg_server_update_rollapp_test.go b/x/rollapp/keeper/msg_server_update_rollapp_test.go
@@ -44,6 +44,7 @@ func (s *RollappTestSuite) TestUpdateRollapp() {
 
 	tests := []struct {
 		name     string
+		sealed   bool
 		update   *types.MsgUpdateRollappInformation
 		expError error
 		mallete  func(expected *types.Rollapp)
@@ -98,11 +99,15 @@ func (s *RollappTestSuite) TestUpdateRollapp() {
 		},
 		{
 			name: "Update rollapp: success - update only metadata",
-			update: &types.MsgUpdateRollappInformation{
-				Owner:     alice,
-				RollappId: rollappId,
-				Metadata:  &mockRollappMetadata,
-			},
+			update: types.NewMsgUpdateRollappInformation(
+				alice,
+				rollappId,
+				"",
+				sdk.Coin{},
+				&mockRollappMetadata,
+				nil,
+			),
+			sealed:   true,
 			expError: nil,
 			mallete: func(expected *types.Rollapp) {
 				expected.Metadata = &mockRollappMetadata
@@ -193,6 +198,8 @@ func (s *RollappTestSuite) TestUpdateRollapp() {
 			goCtx := sdk.WrapSDKContext(s.Ctx)
 
 			rollapp := types.NewRollapp(alice, rollappId, "*", types.DefaultMinSequencerBondGlobalCoin, types.Rollapp_EVM, &types.RollappMetadata{}, gInfo)
+			rollapp.Launched = tc.sealed
+			rollapp.GenesisInfo.Sealed = tc.sealed
 			s.k().SetRollapp(s.Ctx, rollapp)
 
 			_, err := s.msgServer.UpdateRollappInformation(goCtx, tc.update)