Fetch chunks using concurrent requests #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only applies if the chunk is large enough. Same logic as with manifests. This still doesn't apply to virtual chunks, only native. For no reason, we can follow up with virtual chunks in a different PR. This commit also fixes a bug in chunks with offset != 0 (wich cannot be constructed in IC today)
paraseba
force-pushed
the
push-zktltwltvpox
branch
from
f035254 to
508789a
Compare
dcherian
reviewed
Jan 9, 2025
| @@ -322,25 +323,27 @@ where | |||
|
|
|||
| /// Split an object request into multiple byte range requests | |||
| /// | |||
| /// Returns tuples of (offset, size) for each request. It tries to generate the maximum number of | |||
| /// Returns tuples of Range for each request. It tries to generate the maximum number of | |||
dcherian
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only applies if the chunk is large enough. Same logic as with manifests.
This still doesn't apply to virtual chunks, only native. For no reason, we can follow up with virtual chunks in a different PR.
This commit also fixes a bug in chunks with offset != 0 (wich cannot be constructed in IC today)